Date: Sat, 8 Mar 2014 11:24:38 -0600 (CST) From: Karl Denninger <karl@fs.denninger.net> To: FreeBSD-gnats-submit@freebsd.org Subject: ia64/187379: Attempting to buildworld to 10-STABLE from 9.2-STABLE blows Message-ID: <201403081724.s28HOcrv075316@fs.denninger.net> Resent-Message-ID: <201403081730.s28HU0pi016703@freefall.freebsd.org>
index | next in thread | raw e-mail
>Number: 187379
>Category: ia64
>Synopsis: Attempting to buildworld to 10-STABLE from 9.2-STABLE blows
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ia64
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 08 17:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Karl Denninger
>Release: FreeBSD 9.2-STABLE amd64
>Organization:
Karls Sushi and Packet Smashers
>Environment:
System: FreeBSD NewFS.denninger.net 9.2-STABLE FreeBSD 9.2-STABLE #8 r256048M: Fri Oct 4 08:35:51 CDT 2013 karl@NewFS.denninger.net:/usr/obj/usr/src/sys/KSD-SMP amd64
>Description:
With "ORGANIZATION" defined (as above) in the environment build blows
up in subversion. The offending file appears to be
/usr/src/usr.bin/svn/svn/Makefile, which echoes the variable into an
include file without quotes around the string literal; said define
is then used in the source without being quoted.
>How-To-Repeat:
Define "ORGANIZATION" in your environment on a checked-out copy of
10-STABLE's source and type "make buildworld"
>Fix:
[root@NewFS /usr/src/usr.bin/svn/svn]# diff -c Makefile.orig Makefile
*** Makefile.orig Sat Mar 8 10:04:11 2014
--- Makefile Sat Mar 8 10:41:08 2014
***************
*** 58,64 ****
CLEANFILES+= freebsd-organization.h
CFLAGS+= -I. -DHAS_ORGANIZATION_NAME
freebsd-organization.h:
! @echo '#define ORGANIZATION_NAME ${ORGANIZATION}' \
> freebsd-organization.h
.endif
--- 58,64 ----
CLEANFILES+= freebsd-organization.h
CFLAGS+= -I. -DHAS_ORGANIZATION_NAME
freebsd-organization.h:
! @echo '#define ORGANIZATION_NAME "${ORGANIZATION}"' \
> freebsd-organization.h
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
up in subversion
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403081724.s28HOcrv075316>