Date: Mon, 29 Oct 2012 11:15:23 +0100 From: Marko Zec <zec@fer.hr> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-net@freebsd.org, Hans Petter Selasky <hselasky@freebsd.org>, freebsd-hackers@freebsd.org Subject: Re: VIMAGE crashes on 9.x with hotplug net80211 devices Message-ID: <201210291115.23845.zec@fer.hr> In-Reply-To: <CAJ-VmokdwGQGYG4pN6gL=C90VAL2rETgzRH%2B0diiD9w=_HVLoQ@mail.gmail.com> References: <CAJ-VmomchJZ7GUKrAjmmyBXDw-6H6O5fAxT_tfAFfhU=HknG1g@mail.gmail.com> <CAJ-VmomnCFhwzs%2B6FVkFmHscnGop7NHxK3pzddStjD3QSMb%2B2g@mail.gmail.com> <CAJ-VmokdwGQGYG4pN6gL=C90VAL2rETgzRH%2B0diiD9w=_HVLoQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 28 October 2012 19:47:20 Adrian Chadd wrote:
> ping?
>
> Marko - would you be willing to add the if_free() vnet context setup into
> -HEAD?
Feel free to do it - though I'd suggest to use the CURVNET_SET_QUIET()
variant there, to reduce the console spam with VNET_DEBUG.
Marko
Index: if.c
===================================================================
--- if.c (revision 242304)
+++ if.c (working copy)
@@ -513,7 +513,9 @@
if (!refcount_release(&ifp->if_refcount))
return;
+ CURVNET_SET_QUIET(ifp->if_vnet);
if_free_internal(ifp);
+ CURVNET_RESTORE();
}
/*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210291115.23845.zec>