Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 24 Jul 2016 12:42:54 +0100
From:      David Chisnall <theraven@FreeBSD.org>
To:        Emmanuel Vadot <manu@bidouilliste.com>
Cc:        Ed Maste <emaste@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: Call for Testing: Switching back to our BSD licensed dtc(1)
Message-ID:  <A4DA73D1-D2F8-4E15-AD10-F9263396A9E1@FreeBSD.org>
In-Reply-To: <20160719214947.ae2edc38528eaaab1388403f@bidouilliste.com>
References:  <CAPyFy2A71h5WYXR4cNoDRZ-sB2FWmJva6FFNX4jtSZqH=JxpMg@mail.gmail.com> <20160719214947.ae2edc38528eaaab1388403f@bidouilliste.com>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
Thanks,

On 19 Jul 2016, at 20:49, Emmanuel Vadot <manu@bidouilliste.com> wrote:
> 
> 
> Hello,
> 
> I've just tried bsd dtc on all arm dts that we have.
> It doesn't seems to handle multiple include directories.
> Here is how to reproduce :
> 
> $ export SRCROOT=/path/to/fbsd/src
> $ export MACHINE=arm
> $ cd $SRCROOT/sys/boot/fdt/dts/arm
> $ $SRCROOT/sys/tools/fdt/make_dtb.sh $SRCROOT/sys
> beaglebone-black.dts . converting beaglebone-black.dts
> -> ./beaglebone-black.dtb Unable to open file
> '/home/elbarto/Work/freebsd/freebsd.git//sys/boot/fdt/dts/arm/am33xx-clocks.dtsi'.
> No such file or directory Unable to open file
> '/home/elbarto/Work/freebsd/freebsd.git//sys/boot/fdt/dts/arm/tps65217.dtsi'.
> No such file or directory
> 
> Both dtsi files are include with /include/ (i.e. not handled by cpp).
> make_dtb.sh specify : -i $S/boot/fdt/dts/${MACHINE} -i
> $S/gnu/dts/${MACHINE}, it looks like the second one isn't added to the
> list.

It actually is added to the list and found.  The bug here is in error reporting - it was reporting an error for each file that it tried to open but couldn’t, even when it subsequently found the correct file.

> 
> Trying tegra124-jetson-tk1-fbsd.dts give this :
> converting tegra124-jetson-tk1-fbsd.dts
> -> /tmp/bsd_dtb//tegra124-jetson-tk1-fbsd.dtb Error on line 1214:
> Expected node name interrupt-affinity = <&{/cpus/cpu@0}>,
>                         ^
> Error on line 1214: Expected ; at end of property
>  interrupt-affinity = <&{/cpus/cpu@0}>,
>                         ^
> Failed to parse tree.  Unhappy face!

There was a FIXME relating to this in the code.  

I’ve now fixed both of these in the version here:

https://github.com/davidchisnall/dtc

I’ll push the changes to FreeBSD svn soon, but in the meantime anyone wanting to test can just clone that repo over the dtc directory in their src checkout.

David


[-- Attachment #2 --]
0	*H
010	+0	*H

00"kg}0z$F`0
	*H
0u10	UIL10U

StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA0
160419092742Z
170419092742Z0D10Utheraven@freebsd.org1#0!	*H
	theraven@freebsd.org0"0
	*H
0
!htֆ[J
^=*':#Y6"ӊ ؊cR_0WZ=Rx4	asPm&0:P2>u=NbLn]E}$$ xS4ǖRI68RpO֔{\oz;)D=SOM^#;Ԡ*Y߆mbf/+hBӅuQ@ڭʫ&8@Xm00U0U%0++0	U00Us[Ddp=0U#0$l9aIF+('Hmh0o+c0a0$+0http://ocsp.startssl.com09+0-http://aia.startssl.com/certs/sca.client1.crt08U10/0-+)'http://crl.startssl.com/sca-client1.crl0U0theraven@freebsd.org0#U0http://www.startssl.com/0FU ?0=0;+70,0*+http://www.startssl.com/policy0
	*H
R1m
=.A#6n-B;w5'zGL:=E44hOaŹi}l}{f!_Fh+MDZu!K&ECE~PWѥftB+UcEKD&3V]g,}{-)M[_!8jJ&a͒N"jԫt2ךz0ζ=|E?<viA2W9&_u{:u۲\E00ʠk}
׈Q
Y0
	*H
0}10	UIL10U

StartCom Ltd.1+0)U"Secure Digital Certificate Signing1)0'U StartCom Certification Authority0
151216010005Z
301216010005Z0u10	UIL10U

StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA0"0
	*H
0
}â}[[_u$Wy5	|̔
vnqY)\aL$dYG|B"QǤĩVD#'F	k9O_]*ςz_kU.u3r	#:C<ogT)K
Xah8v[\KqdlO)3+u7J5";[vfL/"2ϩJ#4ד[U TB,a˖a7H<=qd0`0U0U%0++0U002U+0)0'%#!http://crl.startssl.com/sfsca.crl0f+Z0X0$+0http://ocsp.startssl.com00+0$http://aia.startssl.com/certs/ca.crt0U$l9aIF+('Hmh0U#0N@[i04hCA0?U 80604U 0,0*+http://www.startssl.com/policy0
	*H
[#'#4pnRۡЗN⛭`]K"#H*߷Թψ;UA8Ҟeg{ozmYE60A)wXRK6c^-Al^k[':G=;oLv{$B5;8b,ZP4{o[-໢j	׏m)[땭[4	s.c|ҴvYLJ<|ӯgu0jD2
@hl+:j\ze_ևa@HyMHINxpK?%	㤺RC:=?^&7m´)A2;E~VB1$EvcKj؝(OoپU`"$a;ҡj0$&<$ۊ+/xjzb,7}W*1ܺtDv#8K
%^P>/i?)yRuQg^z`~sP91N0J00u10	UIL10U

StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA"kg}0z$F`0	+0	*H
	1	*H
0	*H
	1
160724114255Z0#	*H
	1MC"	+$m	9e %0	+7100u10	UIL10U

StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA"kg}0z$F`0*H
	10u10	UIL10U

StartCom Ltd.1)0'U StartCom Certification Authority1#0!UStartCom Class 1 Client CA"kg}0z$F`0
	*H
fhFʖ?X(#Ec
hރmZgNhV=W[oA/;RU5NGܮ! Ӛ\ʁR)4d듦ED8-3`A5ſÙ
c2ً 7zAAJQ^t03ḦrvZ|sGޞ]T~:,FisLʡUûy춣O}x;
 ֏G!
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A4DA73D1-D2F8-4E15-AD10-F9263396A9E1>