Date: Mon, 07 Nov 2016 11:25:41 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 213993] math/kmplot: fix for lang/gcc5 Message-ID: <bug-213993-13-XuTGDbM1C8@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-213993-13@https.bugs.freebsd.org/bugzilla/> References: <bug-213993-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213993 Kenneth Salerno <kennethsalerno@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176421|0 |1 is obsolete| | --- Comment #7 from Kenneth Salerno <kennethsalerno@yahoo.com> --- Created attachment 176715 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D176715&action= =3Dedit view.cpp patch Patch as requested. Tested successfully with __MAKE_CONF=3D/dev/null (clang= ) and lang/gcc5. Note 1: Original source was already including cmath - no change there Note 2: By adding std::, the existing lines become unnecessary #if defined(Q_CC_MINGW) using namespace std; #endif Note 3: The reason clang++ does not need std:: to call isnan/isinf in scope is beca= use LLVM's /usr/include/c++/v1/cmath has "using ::isnan/::isinf" defined as wel= l as namespace std { }. Either patch version will work, I just think my patch would have been easie= r to maintain than touching view.cpp on so many lines that could get adjusted in future releases and be a headache. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-213993-13-XuTGDbM1C8>