Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Oct 2021 06:18:48 +0000
From:      "Piotr P. Stefaniak" <pstef@freebsd.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: bf8f6ffcb66a - main - Mention kern.timecounter.alloweddeviation in nanosleep.1
Message-ID:  <YWE0SMhAFZ1RpPZQ@freefall.freebsd.org>
In-Reply-To: <YWEuROlkDP9NckS%2B@kib.kiev.ua>
References:  <202110081509.198F94HG022514@gitrepo.freebsd.org> <YWEuROlkDP9NckS%2B@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-10-09 08:53:08, Konstantin Belousov wrote:
>On Fri, Oct 08, 2021 at 03:09:04PM +0000, Piotr Pawel Stefaniak wrote:
>> @@ -93,6 +93,8 @@ returns immediately and the calling thread is not suspended.
>>  .Pp
>>  The suspension time may be longer than requested due to the
>>  scheduling of other activity by the system.
>> +It is also subject to the allowed time interval deviation
>> +specified by the sysctl kern.timecounter.alloweddeviation.
>This should be like
>.Xr sysctl 3
>.Dv kern.timecounter.alloweddeviation

@@ -94,7 +94,9 @@ returns immediately and the calling thread is not suspended.
  The suspension time may be longer than requested due to the
  scheduling of other activity by the system.
  It is also subject to the allowed time interval deviation
-specified by the sysctl kern.timecounter.alloweddeviation.
+specified by the
+.Xr sysctl 3
+.Dv kern.timecounter.alloweddeviation .
  An unmasked signal will terminate the sleep early, regardless of the
  .Dv SA_RESTART
  value on the interrupting signal.

>And then, it is missing a description what exactly is allowed by deviation,
>for instance, what units this sysctl is?

That would be redundant with sysctl -d. The point of this change is that now
the user is much more likely to know of the sysctl and can look it up and read
all about it.

The bug may be that there isn't much documentation to be read about it, only
sysctl -d and kern_tc.c.

The only thing I worry that may be missing from this change is this reference
in any other manual pages that might need it as much as nanosleep.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YWE0SMhAFZ1RpPZQ>