Date: Sun, 28 Jul 2013 14:44:56 +0200 From: Tijl Coosemans <tijl@coosemans.org> To: David Chisnall <theraven@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r253563 - head/contrib/libstdc++/include/c_std Message-ID: <20130728144456.486359e0@kalimero.tijl.coosemans.org> In-Reply-To: <B2D786F9-E807-4F9D-89BA-A2B244B87C99@FreeBSD.org> References: <201307231023.r6NANhGf065713@svn.freebsd.org> <20130725201948.2f5ae808@kalimero.tijl.coosemans.org> <7D9DA326-0F32-44D2-92F9-EED0751F9AE0@FreeBSD.org> <20130726122654.19448832@kalimero.tijl.coosemans.org> <B2D786F9-E807-4F9D-89BA-A2B244B87C99@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/sMaHl=NSlGb1CPzpvCdD.I_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 26 Jul 2013 11:51:43 +0100 David Chisnall wrote: > On 26 Jul 2013, at 11:26, Tijl Coosemans <tijl@coosemans.org> wrote: >> On Fri, 26 Jul 2013 10:43:07 +0100 David Chisnall wrote: >>> On 25 Jul 2013, at 19:19, Tijl Coosemans <tijl@coosemans.org> wrote: >>>> This also >>>> broke compilation of C code with -D_XOPEN_SOURCE=3D500. >>>=20 >>> Do you have a test case for this? >>=20 >> % cc -c test.c -D_XOPEN_SOURCE=3D500 -Wall -std=3Dgnu89 >> test.c:5:10: warning: implicit declaration of function 'isnan' >> [-Wimplicit-function-declaration] >> return( isnan( d )); >> ^ >> 1 warning generated. >>=20 >> The isnan function is part of SUSv2: >> http://pubs.opengroup.org/onlinepubs/7990989775/xsh/isnan.html >>=20 >> _XOPEN_SOURCE is handled in sys/cdefs.h. It sets the following macros: >> #define __XSI_VISIBLE 500 >> #define __POSIX_VISIBLE 199506 >> #define __ISO_C_VISIBLE 1990 >=20 > So, isnan and isinf should be visible in functions when in > __ISO_C_VISIBLE < 1999 and __XSI_VISIBLE < 600, and __XSI_VISIBLE >=3D 5= 00? Is it possible to put them back where they were but behind #if __cplusplus < 201103L ? That would be the least disruptive. --Sig_/sMaHl=NSlGb1CPzpvCdD.I_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iF4EAREIAAYFAlH1Ek0ACgkQfoCS2CCgtivDJAD+LWmjpWTZoY5liBpgRUgMUKvr +xAsX9JTmw84SCxrDrMA/1nnfUvMqaSZjldlr7RHNPYxnAY/pvAbvc9Pf5SB3P8a =99UG -----END PGP SIGNATURE----- --Sig_/sMaHl=NSlGb1CPzpvCdD.I_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130728144456.486359e0>