Date: Tue, 03 Jan 2012 15:49:12 -0800 From: Sean Bruno <seanbru@yahoo-inc.com> To: Florian Smeets <flo@freebsd.org> Cc: "mckusick@mckusick.com" <mckusick@mckusick.com>, Don, "current@freebsd.org" <current@freebsd.org>, Lewis <truckman@freebsd.org>, "attilio@freebsd.org" <attilio@freebsd.org>, "phk@phk.freebsd.dk" <phk@phk.freebsd.dk>, Kostik Belousov <kostikbel@gmail.com> Subject: Re: dogfooding over in clusteradm land Message-ID: <1325634552.17931.2.camel@hitfishpass-lx.corp.yahoo.com> In-Reply-To: <4F02F8A6.2000802@freebsd.org> References: <201201030235.q032ZY4V006462@gw.catspoiler.org> <201201030802.q0382M5a006876@gw.catspoiler.org> <20120103091819.GN50300@deviant.kiev.zoral.com.ua> <4F02F8A6.2000802@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-SKRSm0uSuBrWz1Pq7M8e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Tue, 2012-01-03 at 04:46 -0800, Florian Smeets wrote:
> Yes, the patch fixes the problem. The cvs2svn run completed this time.
>=20
> 9132.25 real 8387.05 user 403.86 sys
>=20
> I did not see any significant syncer activity in top -S anymore.
>=20
> Thanks a lot.
> Florian=20
Currently running stable-9 + this patch on crush.freebsd.org. First run
was successful and took about 4 hours start to finish. Nicely done
folks.
diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c
index 716916f..52fc08b 100644
--- a/sys/vm/vm_object.c
+++ b/sys/vm/vm_object.c
@@ -841,7 +841,8 @@ rescan:
if (p->valid =3D=3D 0)
continue;
if (vm_page_sleep_if_busy(p, TRUE, "vpcwai")) {
- if (object->generation !=3D curgeneration)
+ if ((flags & OBJPC_SYNC) !=3D 0 &&
+ object->generation !=3D curgeneration)
goto rescan;
np =3D vm_page_find_least(object, pi);
continue;
@@ -851,7 +852,8 @@ rescan:
n =3D vm_object_page_collect_flush(object, p, pagerflags,
flags, &clearobjflags);
- if (object->generation !=3D curgeneration)
+ if ((flags & OBJPC_SYNC) !=3D 0 &&
+ object->generation !=3D curgeneration)
goto rescan;
/*=20
--=-SKRSm0uSuBrWz1Pq7M8e
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQEcBAABAgAGBQJPA5PqAAoJEL2UHwafTLtO3GoH/2Rh21mDAxx5TNjmTdqXehoy
vzNw8G8UqepX/7dxH7zA4YEuW9MLVOBxKSlvBPC+ceKi+e60AHhJ8IKBntGACp/v
JUu2CQVrKk8MMqASgVxYpvrnMWm9RG1CGdNdZaAG0Sg7X6c5UEs2qaIFwEp2hmvz
QWFpo87PFN+BhZBFJTBN9EsNl/AOjFEknTFd1nFKq/sEnSpyAhbvZfuXZOdwG1K+
eZ/3KkRLZSijiKgNgq9M3/RiKNV2lLDmJO5Rn4/uIDbq98hM220NHuQt5LRznuzt
VZHs6j/iFlnaBGu24O/JxCexJ6LOzCUyT5mlDDlhR5/h7pWXT306eo4237S90Zw=
=aMec
-----END PGP SIGNATURE-----
--=-SKRSm0uSuBrWz1Pq7M8e--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1325634552.17931.2.camel>