Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Mar 1997 11:36:07 PST
From:      Bill Fenner <fenner@parc.xerox.com>
To:        Warner Losh <imp@freefall.freebsd.org>
Cc:        CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org
Subject:   Re: cvs commit: src/sbin/ping ping.c ping.8 
Message-ID:  <97Mar2.113620pst.177476@crevenia.parc.xerox.com>
In-Reply-To: Your message of "Sat, 01 Mar 97 22:32:45 PST." <199703020632.WAA24916@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@freefall.freebsd.org> wrote:
>  3) Don't print all replies unless verbose and root (from idea in
>     OpenBSD ping.c 1.10 and 1.11) to avoid leaking information available
>     only to root.

Is it a good idea to call getuid() for each packet?  Wouldn't it make
more sense to cache its value, since it's not going to change?  (Perhaps
at the same time as we setuid(getuid())?)

  Bill



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?97Mar2.113620pst.177476>