Date: Thu, 31 Dec 2015 12:38:50 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: John Baldwin <john@baldwin.cx> Cc: Garrett Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r292975 - stable/10/sys/dev/pci Message-ID: <633EF3EE-0899-45A1-B12C-CC2290A1FA29@gmail.com> In-Reply-To: <2893860.oDiG4KQizb@ralph.baldwin.cx> References: <201512310355.tBV3t2VG040656@repo.freebsd.org> <2893860.oDiG4KQizb@ralph.baldwin.cx>
index | next in thread | previous in thread | raw e-mail
> On Dec 31, 2015, at 08:42, John Baldwin <john@baldwin.cx> wrote: > > On Thursday, December 31, 2015 03:55:02 AM Garrett Cooper wrote: >> Author: ngie >> Date: Thu Dec 31 03:55:02 2015 >> New Revision: 292975 >> URL: https://svnweb.freebsd.org/changeset/base/292975 >> >> Log: >> MFC r278860: >> r278860 (by jmg): >> >> remove NULL check as M_WAITOK will not return NULL >> >> Reviewed by: jhb >> Sponsored by: FreeBSD Foundation > > Including the metadata from the HEAD commit in the MFC can be misleading, and > I think it is best ommitted. For example, I did not review this MFC (and > reviewing MFC's in their own right matters since they may require additional > work than commits to HEAD due to ABI concerns), nor did the Foundation sponsor > the MFC. Rather, I think MFCs should only specify metadata related to the > actual merge itself. Agreed. I’ve changed my mfc_log script to skip over some more unnecessary svn log metadata: https://github.com/yaneurabeya/scratch/commit/4f897efb96f96f951ff3909857f67e63b24b733a . Thanks :)! -NGiehelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?633EF3EE-0899-45A1-B12C-CC2290A1FA29>