Date: Tue, 22 Feb 2005 10:11:14 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in_pcb.c Message-ID: <20050222081114.GA32753@ip.net.ua> In-Reply-To: <200502220739.j1M7dGGk012347@repoman.freebsd.org> References: <200502220739.j1M7dGGk012347@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 22, 2005 at 07:39:15AM +0000, Gleb Smirnoff wrote: > glebius 2005-02-22 07:39:15 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/netinet in_pcb.c=20 > Log: > In in_pcbconnect_setup() remove a check that route points at > loopback interface. Nobody have explained me sense of this check. > It breaks connect() system call to a destination address which is > loopback routed (e.g. blackholed). > =20 > Reviewed by: silence on net@ > MFC after: 2 weeks > =20 > Revision Changes Path > 1.159 +2 -4 src/sys/netinet/in_pcb.c >=20 =46rom reading the code and Stevens TCP/IP Ill. (which doesn't make things more clear), I think the intent of this code was to select the "best" route such that an address selected could be routed over the network. But I don't think this is appropriate behavior and I like your change. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFCGukiqRfpzJluFF4RAucGAJ9WsE9OjX37VZHqb/TI6reAcKREOwCfbHe2 VO+Isbw+yLHqrz5q3XA790Q= =uGE7 -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050222081114.GA32753>