Date: Mon, 15 Jan 2024 08:30:13 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: df834e06bbc7 - main - git-arc: Just strip escape sequences form arc log Message-ID: <de314243-7cac-4f1c-b013-5c6c8cadd0bc@FreeBSD.org> In-Reply-To: <202401150224.40F2OSBS093537@gitrepo.freebsd.org> References: <202401150224.40F2OSBS093537@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/14/24 6:24 PM, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=df834e06bbc78c03cb6b35f074ae43673c9ce463 > > commit df834e06bbc78c03cb6b35f074ae43673c9ce463 > Author: Warner Losh <imp@FreeBSD.org> > AuthorDate: 2024-01-15 02:22:04 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2024-01-15 02:23:45 +0000 > > git-arc: Just strip escape sequences form arc log > > Just strip escape sequences and Warning: lines from 'arc list' output. I > upgraded and they changed and git arc list broke. This restores its > functionality. > > Note: jhb didn't like this, so if others object, I'll fix... > > Sponsored by: Netflix > Reviewed by: markj > Differential Revision: https://reviews.freebsd.org/D36553 Namely, it breaks the color output for reviews in different states, so Needs Review shows up as purple, Approved as green, etc. If you find the color output useful you'll have to revert this locally. Also, your last update in the review said that git arc was no longer broken for you back in May implying this commit wasn't needed for git arc to work for you? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?de314243-7cac-4f1c-b013-5c6c8cadd0bc>