Date: Mon, 18 Nov 2019 12:50:33 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Mark Johnston <markj@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Alan Somers <asomers@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r354824 - head/lib/geom/part Message-ID: <201911182050.xAIKoX32000661@slippy.cwsent.com> In-Reply-To: <20191118204836.GB43295@raichu> References: <201911181905.xAIJ5q6A068355@repo.freebsd.org> <CAOtMX2hBeW67S4-8m8za1kakmk3Ks34KRC7t75Mwbb1upLku8A@mail.gmail.com> <20191118194501.GA43295@raichu> <CAOtMX2hmNUqB%2BXbTC8cLGEkqUjqfzO_fvO91RwWJaeChV=xDng@mail.gmail.com> <20191118203529.GA64688@FreeBSD.org> <20191118204836.GB43295@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20191118204836.GB43295@raichu>, Mark Johnston writes: > On Mon, Nov 18, 2019 at 08:35:30PM +0000, Alexey Dokuchaev wrote: > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston <markj@freebsd.org> wrote: > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston <markj@freebsd.org> > > > > wrote: > > > > > > > > > > > Author: markj > > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > > New Revision: 354824 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > > > Log: > > > > > > Fix grammar in gpart.8. > > > > > > > > > > > > PR: 241973 > > > > > > MFC after: 3 days > > > > > > > > > > > > Modified: > > > > > > head/lib/geom/part/gpart.8 > > > > > > > > > > Don't forget to bump the .Dd date. > > > > > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > > > > > Isn't that a content change? I thought anything displayed to the user > > > counts as a content change? > > > > I presume that "content" means more like semantic, functional changes > > that affect some particular meaning. Grammar fixes are just, well, > > grammar fixes and thus do not warrant .Dd bump. > > Indeed, this was always my understanding as well. I can't find a > concrete definition anywhere. I don't understand why it would be useful > as a user to see the date of the last "content change" if such changes > might consist only of a small formatting change or typo fix. > Should this be documented in the committers guide? -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911182050.xAIKoX32000661>