Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 03 Aug 2024 01:03:48 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 280566] tree(3) man page: Fix example source code.
Message-ID:  <bug-280566-227-kYJG0wqngp@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-280566-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280566

Maxim Konovalov <maxim@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maxim@FreeBSD.org

--- Comment #1 from Maxim Konovalov <maxim@FreeBSD.org> ---
Hi,

Thanks for the patch!

Just for the record, it seems that there are several separate issues with the
example, specifically:

(1) RB_AUGMENT macro should be defined as early as possible.  Otherwise it is
no-op and the program doesn't work as intended, e.g., it doesn't calculate sum
of the tree elements.

(2) Man page formatting error that leads to a compilation error if you try to
copy-paste the code.

(3) There is also a missed new line between the tree structure content and the
sum of the elements but it looks minor.

I created a slightly better looking to me patch to address all of the above.

Dear Hodong, are you good with this one?

Thanks,

Maxim

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280566-227-kYJG0wqngp>