Date: Tue, 5 Oct 1999 10:48:21 -0400 (EDT) From: Luoqi Chen <luoqi@watermarkgroup.com> To: freebsd-current@FreeBSD.ORG, marcel@scc.nl Cc: jdp@polstra.com Subject: Re: CVSup segfaults identified/solved [PATCH] Message-ID: <199910051448.KAA19616@lor.watermarkgroup.com>
next in thread | raw e-mail | index | archive | help
> Hi, > > It seems that the trampoline code got too long and resulted in the > coredumps people reported. The following patch solves that. it basicly > works as follows: > > o Simplify the trampoline code so that it doesn't have to distinguish > between an old- and new sigframe and also restoring %gs in both > cases. > o Which sigreturn to use is now determined by the process flag that > is used to determine which sendsig is to be used (symmetry) > o restoring %gs is now handled in the proper sigreturn. > > I'll commit this if noone objects. > > -- > Marcel Moolenaar mailto:marcel@scc.nl > SCC Internetworking & Databases http://www.scc.nl/ > The FreeBSD project mailto:marcel@FreeBSD.org Restoration of %gs should not be in the kernel because it comes from user application and maybe invalid, if you restore it inside the kernel it could be fatal to the whole system, and on the other hand just a core dump if done in the trampoline code which is still in user mode. -lq To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199910051448.KAA19616>