Date: Mon, 12 Feb 2024 08:25:37 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 7171c7f8895a - main - sysutils/htop: update to 3.3.0 Message-ID: <CAFDf7UJFK5iQqXKFqkrVT3q%2BcktWrO2%2B99nvGcEkCtnbqr0SBQ@mail.gmail.com> In-Reply-To: <CAGwOe2boSSm95as4VEMiwUdzRD7Wvx2Da=9_k6Bc2MHxdHYx0w@mail.gmail.com> References: <202402081651.418GplWm053715@gitrepo.freebsd.org> <CAFDf7UKMNv1GM4gbp=06LNQQC23v1%2BHG44zLE%2BbiMLKH4cwpMg@mail.gmail.com> <CAGwOe2ZN6X5XD6Q4YGtfX8TV1xZmMEnuaPBXtELpRhGNqLZ0zA@mail.gmail.com> <CAFDf7UJnGsJcf7fn_-7LLMMLq3JmEd7eiFNZbM%2BnQM9Q24GKBg@mail.gmail.com> <CAGwOe2boSSm95as4VEMiwUdzRD7Wvx2Da=9_k6Bc2MHxdHYx0w@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
It was discussed a long time ago and portlint was changed to follow it:
if ($_ =~ m|\.desktop$| && $makevar{USES} !~ /\bdesktop-file-utils\b/) {
&perror("WARN", $file, $., "this port installs
.desktop files. ".
"If the .desktop file(s) installed
contain ``MimeType='', ".
"you must add `desktop-file-utils` to USES.");
Fernando Apesteguía <fernape@freebsd.org> escreveu (domingo,
11/02/2024 à(s) 21:29):
>
>
>
> El dom, 11 feb 2024, 20:28, Nuno Teixeira <eduardo@freebsd.org> escribió:
>>
>> It is, but maybe not in the best place/section:
>>
>> https://docs.freebsd.org/en/books/porters-handbook/book/#updating-desktop-database
>
>
> Not quite in my opinion. That says that if the .desktop contains MimeType then desktop-file-utilsshould be used. It doesn't say that *only in that case* it should be used.
>
>>
>>
>> Fernando Apesteguía <fernape@freebsd.org> escreveu (domingo,
>> 11/02/2024 à(s) 18:48):
>> >
>> >
>> >
>> > On Sun, Feb 11, 2024 at 6:31 PM Nuno Teixeira <eduardo@freebsd.org> wrote:
>> >>
>> >> > -USES= autoreconf compiler:c11 cpe libtool localbase ncurses pkgconfig \
>> >> > - python:build shebangfix
>> >> > +USES= autoreconf compiler:c11 cpe desktop-file-utils libtool localbase \
>> >> > + ncurses pkgconfig python:build shebangfix
>> >>
>> >> desktop-file-utils only needed when .desktop file includes MimeType.
>> >
>> >
>> > I think this comment would be good in the documentation (https://docs.freebsd.org/en/books/porters-handbook/book/#uses-desktop-file-utils)
>> >
>> >>
>> >>
>> >> --
>> >> Nuno Teixeira
>> >> FreeBSD Committer (ports)
>>
>>
>>
>> --
>> Nuno Teixeira
>> FreeBSD Committer (ports)
--
Nuno Teixeira
FreeBSD Committer (ports)
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJFK5iQqXKFqkrVT3q%2BcktWrO2%2B99nvGcEkCtnbqr0SBQ>