Date: Fri, 30 Jan 2026 21:03:57 +0000 From: Colin Percival <cperciva@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 3ab15ea66043 - stable/14 - Ping: Make build reproducible Message-ID: <697d1cbd.3040e.5a54e3bb@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/14 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=3ab15ea66043b7be87914c151ced6c3ccf7d7c0b commit 3ab15ea66043b7be87914c151ced6c3ccf7d7c0b Author: Colin Percival <cperciva@FreeBSD.org> AuthorDate: 2025-10-13 15:58:10 +0000 Commit: Colin Percival <cperciva@FreeBSD.org> CommitDate: 2026-01-30 21:00:35 +0000 Ping: Make build reproducible As recently fixed in sockstat (9934558460e4), having tests/Makefile include files from the parent directory with SRCS= ../foo.c results in a race condition as the parent build and the tests build try to produce the same object file but contain different paths. Use .PATH to tell make to find sockstat.c in the parent directory but place the object file in the current object directory. Reviewed by: emaste, jrtc27, kevans MFC after: 3 days Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D53075 (cherry picked from commit 3c9a2f383fc25cdffa80c1348cb5388290e0f283) --- sbin/ping/tests/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sbin/ping/tests/Makefile b/sbin/ping/tests/Makefile index 3bdf53c15a7c..7fe0d6b173db 100644 --- a/sbin/ping/tests/Makefile +++ b/sbin/ping/tests/Makefile @@ -1,6 +1,7 @@ ATF_TESTS_C+= in_cksum_test -SRCS.in_cksum_test= in_cksum_test.c ../utils.c +.PATH: ${.CURDIR:H} +SRCS.in_cksum_test= in_cksum_test.c utils.c PACKAGE= testshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?697d1cbd.3040e.5a54e3bb>