Date: Tue, 11 Jan 2005 11:13:52 -0800 From: Nate Lawson <nate@root.org> To: John Baldwin <jhb@FreeBSD.org> Cc: freebsd-current@FreeBSD.org Subject: Re: page fault panic in device_get_softc/acpi_pcib_route_interrupt Message-ID: <41E42570.8040503@root.org> In-Reply-To: <D9C48E91-63E1-11D9-A25E-000393921CC4@FreeBSD.org> References: <20587818.1102626838092.JavaMail.tomcat@pne-ps4-sn1> <41DEED05.4040000@root.org> <41DF0839.6040700@telia.com> <200501071728.16828.jhb@FreeBSD.org> <41DF2BB3.60800@root.org> <41DF347E.6010305@telia.com> <41DF5159.1090106@root.org> <41DF5DEA.3030904@telia.com> <41DF9481.5030305@root.org> <41DFA2FF.0@telia.com> <41E02AD7.5000005@root.org> <D9C48E91-63E1-11D9-A25E-000393921CC4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
>
> On Jan 8, 2005, at 1:47 PM, Nate Lawson wrote:
>
>> Pawel Worach wrote:
>>
>>> Nate Lawson wrote:
>>> --- sys/dev/acpica/acpi_pcib.c 27 Dec 2004 05:36:47 -0000 1.53
>>> +++ sys/dev/acpica/acpi_pcib.c 8 Jan 2005 09:05:57 -0000
>>> @@ -249,11 +249,18 @@
>>> /*
>>> * We have to find the source device (PCI interrupt link device).
>>> */
>>> - if (ACPI_FAILURE(AcpiGetHandle(ACPI_ROOT_OBJECT, prt->Source,
>>> &lnkdev))) {
>>> + if (ACPI_FAILURE(AcpiGetHandle(acpi_get_handle(pcib), prt->Source,
>>> + &lnkdev))) {
>>> device_printf(pcib, "couldn't find PCI interrupt link device %s\n",
>>> prt->Source);
>>> goto out;
>>> }
>>
>>
>> This change should not be committed. I think it's correct to use \ to
>> start the search since your _PRT contains relative references but the
>> links are under \.
>
>
> So, should I change the code to force-attach the devices to also use
> ACPI_ROOT_OBJECT for its lookup as well in prt_attach_devices()?
>
Sure, I think that's a good idea.
--
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41E42570.8040503>