Date: Tue, 26 May 2009 10:48:25 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: David Naylor <naylor.b.david@gmail.com> Cc: pgollucci@p6m7g8.com, itetcu@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) Message-ID: <1243327705.43470.8.camel@pav.hide.vol.cz> In-Reply-To: <200905260819.23178.naylor.b.david@gmail.com> References: <200905251003.15408.naylor.b.david@gmail.com> <200905252247.32725.naylor.b.david@gmail.com> <20090526.111343.48515131.chat95@mac.com> <200905260819.23178.naylor.b.david@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-U9xTaKMfK9Pba8mOSn4J
Content-Type: text/plain; charset="ISO8859-2"
Content-Transfer-Encoding: quoted-printable
David Naylor p=ED=B9e v =FAt 26. 05. 2009 v 08:19 +0200:
> pav: ${_MAKE_JOBS:C/-j//} won't work with DISABLE_MAKE_JOBS (or=20
> MAKE_JOBS_UNSAFE) since it needs to always be a positive number, secondly=
it=20
> still cannot be used for conditional code (since it is defined in the pos=
t=20
> section, but the whole code could always be moved to the pre section).=20
I'm hesitant to modify bsd.port.mk for benefit of just four ports.
Also, I think having MAKE_JOBS_NUMBER set to 1 when the feature is in
fact disable, is counter-intuitive (because -j1 is very different to no
-j at all).
So how about just having
.if defined(DISABLE_MAKE_JOBS)
MAKE_JOBS_NUMBER=3D 1
.else
MAKE_JOBS_NUMBER!=3D echo `${SYSCTL} -n kern.smp.cpus`
.endif
in ooo makefile?
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
Go back to bed America, your government is in control again. Here's
American Gladiators. Watch this, shut up. Here's 56 channels of it.
Watch these pituitary retards bang their fuckin skulls together and
congratulate you on living in the land of freedom.
-- Bill Hicks
--=-U9xTaKMfK9Pba8mOSn4J
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkobrNkACgkQntdYP8FOsoL7IQCgqXO9ivAkGBIOJajNG9hGTz3b
qOwAnA+p0VfD8CBs1ktwPDpneSkKz0PI
=x0Gs
-----END PGP SIGNATURE-----
--=-U9xTaKMfK9Pba8mOSn4J--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1243327705.43470.8.camel>