Date: Fri, 23 Aug 2019 10:48:06 -0600 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: Li-Wen Hsu <lwhsu@freebsd.org>, John Baldwin <jhb@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto Message-ID: <CANCZdfq6CRQcZuMr6X%2BTyFwCZm2FFx7qSbZcq%2BD4sUsbE7x3pg@mail.gmail.com> In-Reply-To: <3EE09B22-254B-4415-8865-D9542122ACA5@FreeBSD.org> References: <201908220002.x7M028Jh070116@repo.freebsd.org> <DC49D260-C049-47F3-ADFA-76D793212E16@FreeBSD.org> <0b9d1aa1-d328-30bc-b939-f1407e236855@FreeBSD.org> <CANCZdfq7FOsQNkpRgHZP3yzxhfcGv5gLOzco7tGttTVSrETOfQ@mail.gmail.com> <3EE09B22-254B-4415-8865-D9542122ACA5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 23, 2019 at 10:10 AM Bjoern A. Zeeb <bz@freebsd.org> wrote: > On 23 Aug 2019, at 15:53, Warner Losh wrote: > > > Sorry for top posting... > > > > I had planned this for next week, but I think give this insanity of > > this > > patch, we should do it now: turn off -Werror for gcc 4.2.1 > > > > https://reviews.freebsd.org/D21378 > > > > has the review. There's no benefit to these head-scratcher changes > > when we > > can get the same benefit by ignoring gcc 4.2.1 errors as discussed on > > arch@. > > That brings me to a different question: why does this build > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/lastBuild/ not fail > despite rendering the warnings > There's a lot of -Wno-error and -Wno-error=XXX sprinkled in our build for gcc 4.2.1 today, so we see the warnings but aren't stopped by them. My changes take a big hammer and add a global -Wno-error to CFLAGS last to make this the behavior on gcc 4.2.1 platforms. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq6CRQcZuMr6X%2BTyFwCZm2FFx7qSbZcq%2BD4sUsbE7x3pg>