Date: Thu, 5 Jan 2017 15:02:59 +0000 (UTC) From: jbeich@freebsd.org (Jan Beich) To: db@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r430641 - in head/comms/wsjtx: . files Message-ID: <20170105150259.3BD4A50FB@freefall.freebsd.org> In-Reply-To: <201701051440.v05EeAs3029482@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Diane Bruce <db@FreeBSD.org> writes:
> + libomp.so:devel/openmp
devel/openmp is currently amd64-only, so comms/wsjtx loses i386 support
by unconditionally depending on it.
> CMAKE_ARGS+= -DPORT_BUILDING::STRING="ON" \
> - -DCMAKE_PREFIX_PATH+=${LOCALBASE}/wsjtx/lib
> + -DCMAKE_PREFIX_PATH+=${LOCALBASE}/wsjtx/lib \
> + -DLOCALBASE::STRING="${LOCALBASE}"
[...]
> +if (CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")
> + set (FREEBSD TRUE)
> + link_directories("/usr/lib" "${LOCALBASE}/lib")
> + include_directories("/usr/lib" "${LOCALBASE}/include")
> +endif()
Why not add USES=localbase:ldflags instead? Besides, -I/usr/lib is bogus
while -L/usr/lib is poisonous for lang/gcc*.
> Modified: head/comms/wsjtx/distinfo
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-CMakeLists.txt
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-Radio.cpp
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-WFPalette.hpp
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-manpages_CMakeLists.txt
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/pkg-plist
> ==============================================================================
> Binary file (source and/or target). No diff available.
Can you fix svn:mime-type of these files?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170105150259.3BD4A50FB>