Date: Thu, 16 Nov 2017 09:13:48 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Mark Millard <markmi@dsl-only.net> Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: -r325627 of head: mergemaster: Creating objdir after objdir after . . . Message-ID: <109a5971-236c-1007-21f6-6bd1cbe3a1cb@FreeBSD.org> In-Reply-To: <F962B461-DBA2-4AD6-A6A7-7A20AED4DE1F@dsl-only.net> References: <B60F7C47-D5F5-460B-9018-B59BD0ED621F@dsl-only.net> <08a57ee2-ae3e-b8ea-73a3-b6533b0fd206@FreeBSD.org> <202f44cb-39d6-99af-9804-582825ae5c07@FreeBSD.org> <0c9c20c2-1d34-77e8-1620-fb99881a34d1@FreeBSD.org> <C365F464-7480-4B70-B5B9-D18ED8F2C03E@dsl-only.net> <A38ADD49-423E-4368-B253-56D6E7A034FA@FreeBSD.org> <F962B461-DBA2-4AD6-A6A7-7A20AED4DE1F@dsl-only.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--8Sh14RGwniTvEmiiSCSWS3svwlVLOEa5C
Content-Type: multipart/mixed; boundary="pEfxv5nXReVV17CIb3LFDPTdvITww0S4I";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Mark Millard <markmi@dsl-only.net>
Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org>,
FreeBSD Current <freebsd-current@freebsd.org>
Message-ID: <109a5971-236c-1007-21f6-6bd1cbe3a1cb@FreeBSD.org>
Subject: Re: -r325627 of head: mergemaster: Creating objdir after objdir after
. . .
References: <B60F7C47-D5F5-460B-9018-B59BD0ED621F@dsl-only.net>
<08a57ee2-ae3e-b8ea-73a3-b6533b0fd206@FreeBSD.org>
<202f44cb-39d6-99af-9804-582825ae5c07@FreeBSD.org>
<0c9c20c2-1d34-77e8-1620-fb99881a34d1@FreeBSD.org>
<C365F464-7480-4B70-B5B9-D18ED8F2C03E@dsl-only.net>
<A38ADD49-423E-4368-B253-56D6E7A034FA@FreeBSD.org>
<F962B461-DBA2-4AD6-A6A7-7A20AED4DE1F@dsl-only.net>
In-Reply-To: <F962B461-DBA2-4AD6-A6A7-7A20AED4DE1F@dsl-only.net>
--pEfxv5nXReVV17CIb3LFDPTdvITww0S4I
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 11/11/2017 2:25 PM, Mark Millard wrote:
>=20
> On 2017-Nov-11, at 8:47 AM, Bryan Drewery <bdrewery@FreeBSD.org> wrote:=
>=20
>>> On Nov 11, 2017, at 00:51, Mark Millard <markmi@dsl-only.net> wrote:
>>>
>>>> On 2017-Nov-10, at 5:16 PM, Bryan Drewery <bdrewery at FreeBSD.org> =
wrote:
>>>>
>>>>> On 11/10/2017 8:30 AM, Bryan Drewery wrote:
>>>>> . . .=20
>>>>> In fact it's similar to my META_MODE whitelist in the top-level
>>>>> Makefile. There's quite a few targets we don't care for AUTO_OBJ o=
n,
>>>>> like distribute*, installworld, installkernel, etc.
>>>>
>>>> r325697 should fix it.
>>>
>>> Most of the messages are gone in -r325700 . But there was:
>>>
>>> *** Creating the temporary root environment in /var/tmp/temproot
>>> *** /var/tmp/temproot ready for use
>>> *** Creating and populating directory structure in /var/tmp/temproot
>>>
>>> [Creating objdir /usr/obj/usr/src/arm64.aarch64...]
>>> [Creating objdir /usr/obj/usr/src/arm64.aarch64/etc...]
>>> [Creating objdir /usr/obj/usr/src/arm64.aarch64/etc/sendmail...]
>>>
>>> (No more objdir lines after that.)
>>
>> Yea this is expected. Mergemaster runs =E2=80=98make obj=E2=80=99 in e=
tc/.
>=20
> Hmm. I looking I see the:
>=20
> ${MM_MAKE} _obj SUBDIR_OVERRIDE=3Detc >/dev/null &&
> ${MM_MAKE} everything SUBDIR_OVERRIDE=3Detc >/dev/null &&
>=20
> Its too bad that the mergemaster man page makes no reference
> to depending on MAKEOBJDIRPREFIX (or its default) and the
> tree contents that it points to. If one has more than one
> tree around then one should be picking the right one --but
> nothing in the man page suggests that.
>=20
> It also would not play well with not having that build tree
> available at the time of a mergemaster.
Can you test this patch please in context of this problem please?
It resolves read-only objdirs and should avoid more of the objdir
creations at mergemaster/installworld time. It probably will still
create the etc/sendmail one.
https://people.freebsd.org/~bdrewery/patches/top-level-objdirs.diff
>=20
> The 20130425 UPDATING entry does note use of
> MAKEOBJDIRPREFIX. It notes that mergemaster makes use of the
> specific, bootstrapped mtree and install. Does that mean
> that a cross-build needs mergemaster to be executed on
> the cross-build host instead of on the target system? I do
> not see the man page as well-covering such questions for
> the proper usage technique.
>=20
> Dependency on /usr/src (by default or an alternate via -m) is
> clear from the man page. So, having a proper vintage of such
> and having mergemaster use it was clear. But such seems to not
> be sufficient, which was not clear.
>=20
>> The top-level check-old objdir creation is unavoidable right now... yo=
u can use -DNO_OBJ if you want to avoid it.
>>
>>>
>>>>>
>>>>>> However from reading mergemaster.sh it seems that _at least_
>>>>>> /usr/obj/usr/src/etc/sendmail would be created before my changes. =
Can
>>>>>> someone confirm that on stable/ or something?
>>>>>>
>>>>>>>
>>>>>>> (MAKEOBJDIRPREFIX=3D does control the path-prefix used
>>>>>>> if specified in the env list before mergemaster.)
>>>>>>>
>>>
>=20
>=20
> =3D=3D=3D
> Mark Millard
> markmi at dsl-only.net
>=20
--=20
Regards,
Bryan Drewery
--pEfxv5nXReVV17CIb3LFDPTdvITww0S4I--
--8Sh14RGwniTvEmiiSCSWS3svwlVLOEa5C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJaDcdMAAoJEDXXcbtuRpfPNpYH+gPa1zzx3/pnAh5xtzETjhHx
IVN/5TkxR5n4d14Rl/p1iTLP+UyR4IhCGcQm3hoSnF3jcDeIsPk7CDFTqvfF0mWN
li6B7jd3T8Epa8DZaHQCkynh3TZ9rHXniGNSimQxdpCZ117Sr6m2OdXE2JFvFhE0
yY0I+c/8qcLHO7SDRL/pMoq5+YTYHlHBgfJp5fHg9RdhEgMUv7898QHrJzs1K4e6
zluWbGEbl0AwvepkC5wk72VghRyUsJjYoQDhuUjcKI3dcPIeK4xeNUYh7MMTnGGa
sEjDYjK6TVY9wLdloYWImoyRNLZprvIjLGIXPViSoM/LLqknVbOmnxGcZh51W0g=
=xX9I
-----END PGP SIGNATURE-----
--8Sh14RGwniTvEmiiSCSWS3svwlVLOEa5C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?109a5971-236c-1007-21f6-6bd1cbe3a1cb>