Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Mar 2021 11:33:34 +0100
From:      Hans Petter Selasky <hps@selasky.org>
To:        "Alexander V. Chernikov" <melifaro@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 7563019bc693 - main - Add if_try_ref() to simplify refcount handling inside epoch.
Message-ID:  <1db9ff12-55d7-da4d-dde9-d7e9045fffc4@selasky.org>
In-Reply-To: <202102222338.11MNcBem084739@gitrepo.freebsd.org>
References:  <202102222338.11MNcBem084739@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2/23/21 12:38 AM, Alexander V. Chernikov wrote:
> The branch main has been updated by melifaro:

> diff --git a/sys/net/if_var.h b/sys/net/if_var.h
> index 291a7781d73c..33a737880a8d 100644
> --- a/sys/net/if_var.h
> +++ b/sys/net/if_var.h
> @@ -661,6 +661,7 @@ void	if_link_state_change(struct ifnet *, int);
>   int	if_printf(struct ifnet *, const char *, ...) __printflike(2, 3);
>   void	if_ref(struct ifnet *);
>   void	if_rele(struct ifnet *);
> +bool	if_try_ref(struct ifnet *);

I think you should add __result_use_check for this prototype!?

>   int	if_setlladdr(struct ifnet *, const u_char *, int);
>   int	if_tunnel_check_nesting(struct ifnet *, struct mbuf *, uint32_t, int);
>   void	if_up(struct ifnet *);
> 

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1db9ff12-55d7-da4d-dde9-d7e9045fffc4>