Date: Mon, 29 Jul 2019 19:23:15 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 239509] multimedia/ffmpeg: Fix build dependencies and minor clean-up Message-ID: <bug-239509-12827-fuPqRV8UKr@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-239509-12827@https.bugs.freebsd.org/bugzilla/> References: <bug-239509-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239509 --- Comment #3 from Jan Beich <jbeich@FreeBSD.org> --- (In reply to daniel.engberg.lists from comment #2) > what do you mean by GNU as elsewhere? When building on aarch64 without devel/binutils: =3D=3D=3D> Configuring for ffmpeg-4.2,1 GNU assembler not found, install/update gas-preprocessor which is under the following conditional in configure: if enabled_any arm aarch64 || enabled_all ppc altivec && enabled asm; then Do you see x86 there? > Yes, -O2 it's purely a cosmetic/readability fix > but as that considered bad pratice? Cosmetic changes unnecessarily complicate maintenance. .include <bsd.port.options.mk> is also unnecessary given -O2 comes from sys.mk, not bsd.port.mk. And ${CFLAGS:S/-O2//g} maybe better spelled as ${CFLAGS:N-O*}. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-239509-12827-fuPqRV8UKr>