Date: Fri, 9 Oct 2015 10:23:42 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, <sjg@juniper.net> Subject: Re: svn commit: r288911 - head/share/mk Message-ID: <15686.1444411422@chaos> In-Reply-To: <561693EF.50808@FreeBSD.org> References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com> <5615C935.2060204@FreeBSD.org> <CANCZdfrTppL=umBHYxj-gGrjb8omR3BcocWJtEXkSPAktVOGzg@mail.gmail.com> <561693EF.50808@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I seem to be getting mails out of order... Bryan Drewery <bdrewery@freebsd.org> wrote: > > So why are we including src.conf in sys.mk <http://sys.mk>; and not > > src.opts.mk <http://src.opts.mk>? > > > > We're including it there because Simon wanted it included there so > > meta-mode settings were visible in sys.mk <http://sys.mk>. I thought it > > lame at the > > time, but had no better solution. My recollection is a little vague... there are options that sys.mk needs to be able to use (eg for auto.obj.mk - because .OBJDIR affects .PATH computaion in many cases), but src.conf should be largely orthogonal IIRC src.opts.mk cannot be included early due to it including bsd.own.mk which cases lots of problems when included too early. > Ah! So the /etc/src-env.conf thing I referenced does replace it. So we > can remove src.conf from sys.mk now. It came in via r284598, and I > documented it and added it to src.conf.5/makeman later on. Yes src-env.conf allows for separate conf stuff that is needed early vs late.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15686.1444411422>