Date: Mon, 24 Feb 2014 13:50:41 +0400 From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: Craig Rodrigues <rodrigc@crodrigues.org>, "Bjoern A. Zeeb" <bz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r262351 - head/sys/netinet6 Message-ID: <530B15F1.5050300@FreeBSD.org> In-Reply-To: <CAG=rPVe4J7e192Z9eS%2BoqhkdZujrVn3t5=JsvJ2PT_VA9TF9bg@mail.gmail.com> References: <201402230127.s1N1RMoX052542@svn.freebsd.org> <D23407A9-35AC-4B5A-904D-B1BD333B46C0@FreeBSD.org> <CAG=rPVe4J7e192Z9eS%2BoqhkdZujrVn3t5=JsvJ2PT_VA9TF9bg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24.02.2014 12:34, Craig Rodrigues wrote: > > On Feb 23, 2014 2:56 PM, "Bjoern A. Zeeb" <bz@freebsd.org > <mailto:bz@freebsd.org>> wrote: >> >> >> On 23 Feb 2014, at 01:27 , Craig Rodrigues <rodrigc@FreeBSD.org> wrote: >> >> > Author: rodrigc >> > Date: Sun Feb 23 01:27:22 2014 >> > New Revision: 262351 >> > URL: http://svnweb.freebsd.org/changeset/base/262351 >> > >> > Log: >> > Remove KASSERT from in6p_lookup_mcast_ifp(). >> > >> > When the devel/jenkins port, version 1.551 was started, >> > the kernel would panic if INVARIANTS was enabled in the kernel config. >> > >> > Suggested by: bms >> >> This reads to me “we hit the assert, bms suggested to remove it”. > Great! Caught a bug! Where is it? In no way the commit message tells > me why? Why did we not hit the assert in the last n years? What has > changed that we hit it now? Was the assert wrong from the beginning? > Did we hit a real bug elsewhere and now lost the tracking for it? >> >> Could you please at least for the archives explain? > > Bruce suggested that I remove the KASSERT here: > > http://lists.freebsd.org/pipermail/freebsd-net/2013-October/036806.html There was my analysis: http://lists.freebsd.org/pipermail/freebsd-net/2013-August/036545.html I think it is safe to remove this KASSERT. -- WBR, Andrey V. Elsukov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?530B15F1.5050300>