Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Nov 2003 14:11:15 +0000
From:      Bruce M Simpson <bms@spc.org>
To:        Jeff Roberson <jeff@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/vm uma_core.c
Message-ID:  <20031130141115.GA19707@saboteur.dek.spc.org>
In-Reply-To: <200311300804.hAU84211002538@repoman.freebsd.org>
References:  <200311300804.hAU84211002538@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Jeff,

On Sun, Nov 30, 2003 at 12:04:01AM -0800, Jeff Roberson wrote:
>   Log:
>    - Replace the local maxcpu with mp_maxid.  Previously, if mp_maxid
>      was equal to MAXCPU, we would overrun the pcpu_mtx array because maxcpu
>      was calculated incorrectly.
>    - Add some more debugging code so that memory leaks at the time of
>      uma_zdestroy() are more easily diagnosed.

This change appears to break compilation of uniprocessor kernels. The
mp_maxid variable is defined in kern/subr_smp.c. In a uniprocessor kernel,
this symbol is undefined:-

kimchi:~/cvs/src/sys % nm /boot/kernel/kernel | grep mp_maxid
Exit 1

Regards,
BMS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031130141115.GA19707>