Date: Fri, 13 Jul 2018 16:51:27 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Tobias Kortkamp <tobik@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r474520 - head/x11-clocks/glclock Message-ID: <20180713135127.GK7353@hades.panopticon> In-Reply-To: <1531464216.1955680.1439350032.7AC058F0@webmail.messagingengine.com> References: <201807121411.w6CEBlZn074328@repo.freebsd.org> <1531464216.1955680.1439350032.7AC058F0@webmail.messagingengine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Tobias Kortkamp (tobik@FreeBSD.org) wrote: > > Author: amdmi3 > > Date: Thu Jul 12 14:11:46 2018 > > New Revision: 474520 > > URL: https://svnweb.freebsd.org/changeset/ports/474520 > > > > Log: > > - Fix build with clang 6 > > > > Modified: > > head/x11-clocks/glclock/Makefile > > > > Modified: head/x11-clocks/glclock/Makefile > > ============================================================================== > > --- head/x11-clocks/glclock/Makefile Thu Jul 12 14:11:30 2018 (r474519) > > +++ head/x11-clocks/glclock/Makefile Thu Jul 12 14:11:46 2018 (r474520) > > @@ -15,6 +15,7 @@ USE_GL= gl glu glut > > MAKEFILE= makefile > > > > CFLAGS+= -DIMAGE_PATH="\\\"${PREFIX}/lib/X11/glclock/\\\"" > > +CXXFLAGS+= -Wno-c++11-narrowing > > Why is this needed after r474251? Was the previous fix not enough? It wasn't, I wasn't aware of your fix. > Besides that this breaks the build on Tier 2 archs like powerpc. > gcc 4.2 doesn't recognize -Wno-c++11-narrowing and treats it as an > error: > > cc1plus: error: unrecognized command line option "-Wno-c++11-narrowing" > > I think something like > > USES= compiler > CXXFLAGS+= ${CXXFLAGS_${CHOSEN_COMPILER_TYPE}} > CXXFLAGS_clang= -Wno-c++11-narrowing > > or similar would be better. This is too cumbersome. If it comes to this, this should be added to the framework as compiler:legacycode or something like that. But I really prefer for such fixes it to be in the Makefile and not a patch, as it makes the existence of rotten code more apparent, and makes garbage collecting either the fix (if the code is fixed upstream) or the whole port (as unmaintained legacy) easier. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: https://github.com/AMDmi3
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180713135127.GK7353>