Date: Sat, 25 Jul 2009 18:59:29 GMT From: Dmitrij Tejblum <tejblum@yandex-team.ru> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/137136: [PATCH] Make python support in editor/gedit an explicit option Message-ID: <200907251859.n6PIxTHP094157@www.freebsd.org> Resent-Message-ID: <200907251900.n6PJ09Oh093632@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 137136
>Category: ports
>Synopsis: [PATCH] Make python support in editor/gedit an explicit option
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jul 25 19:00:09 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Dmitrij Tejblum
>Release: 7.2-RELEASE
>Organization:
>Environment:
>Description:
The editors/gedit port check if pygtksourceview is installed, and enable or disable support for python plugins depending on it.
It is not very convenient for a newbie to install the port (without disabling any option!) and then discover that half of its features does not work for a non-obvious reason. Thus I suggest to convert it to an explicit OPTION.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- ports/editors/gedit/Makefile 2009-05-19 18:07:56.000000000 +0400
+++ ports/editors/gedit/Makefile 2009-07-25 22:46:30.000000000 +0400
@@ -41,9 +41,11 @@
WITH_GNOME= yes
.endif
-.include <bsd.port.pre.mk>
+OPTIONS= PYTHON "Enable Python Plugins" On
-.if ${HAVE_GNOME:Mpygtksourceview}!=""
+.include <bsd.port.options.mk>
+
+.ifdef WITH_PYTHON
USE_PYTHON= yes
.include "${PORTSDIR}/Mk/bsd.python.mk"
USE_GNOME+= pygtksourceview
@@ -63,4 +65,4 @@
post-install:
@-update-desktop-database
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907251859.n6PIxTHP094157>