Date: Thu, 29 Aug 2024 07:44:33 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Gleb Popov <arrowd@freebsd.org>, Cy Schubert <cy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options Message-ID: <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> In-Reply-To: <20240828180439.22B0730E@slippy.cwsent.com> References: <202408281603.47SG35Q9035605@gitrepo.freebsd.org> <CALH631nFVYyks4DB%2BT8%2BC8r5Y6GHT4Su8mzhDaJ8BQ1=PMVZPA@mail.gmail.com> <20240828180439.22B0730E@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--t2cwj7kshsfy5exo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote:
> In message <CALH631nFVYyks4DB+T8+C8r5Y6GHT4Su8mzhDaJ8BQ1=3DPMVZPA@mail.gm=
ail.c
> om>
> , Gleb Popov writes:
> > On Wed, Aug 28, 2024 at 7:03=3DE2=3D80=3DAFPM Cy Schubert <cy@freebsd.o=
rg> wrote:
> > >
> > > +# In case devel/elfutils has been previously installed.
> > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebugin=
fod.=3D
> > so)
> > > +LIB_DEPENDS+=3D3D libdebuginfod.so:devel/elfutils
> > > +.endif
> >
> > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in
> > libraries that are missing, but then the "exists" condition will
> > always be false.
>=20
> Correct. The condition will always be false when building with poudriere=
=20
> but for those building the port by hand, and have manually installed=20
> devel/elfutils prior to building and installing manually the condition wi=
ll=20
> then be true.
>=20
> Much committers' dismay some users don't use binary packages, you and I a=
s=20
> committers prefer people use binary packages. But unfortunately this is n=
ot=20
> always the case. The PR was submitted by a person who builds his ports by=
=20
> hand.
It would be better to disable the finding of libdebuginfod in LOCALBASE,
so that everyone has the same binutils, and nobody gets a possibly
different behavior.
--=20
Mathieu Arnold
--t2cwj7kshsfy5exo
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmbQCr9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1
NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d
Qb610Qv/eH3c0+UHjOQ1CC9dLhwiwbM9aRNX1Qj7E+uI1rzBjVqKAyGDFWqkUR0+
sLlvyIPBhR/coI0DZ6x+HbxfT4ob2cFzm7yMhY4tQ2RMrgq1dutoPDvMYE5sP9KS
1Lj93mFTFJGUeFrCdaCUltFNKr+J3cjHMGwauUak+Y3KpjA0PEGqDM9qjZahUFxN
FaGrwwsCxQufId3Xu50WRezAbwl25ymlMWcA3Az0lv63uni2OJrZAXffD4FRnrwV
w3eOM71IH60Rf9/ZmlHx6uO0Xl9ohTRdmEoQECdWURmy8dCy960Fp7J1uVraYQ8Y
A0wbxq8KYAJ4e+OdcLFYD5ARXGtTtMPdp+xfEMrJP3leGMkq5BQMr68d4K0ole4r
seqgo824ksJwuTQo0iLCxCpbNvDM6oD8lKOIk+Q3kRqWir0beOdr1EcOnchplG8E
uoE9ZP8e+oF7ntiIbNRZSlP4s26hGaN/Ah9sSpvQ2dhwj+yAGcDgsVQzUoARWRaa
JTSnICE+
=WpFR
-----END PGP SIGNATURE-----
--t2cwj7kshsfy5exo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4>