Date: Thu, 20 Oct 2016 21:56:15 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307650 - head/sys/kern Message-ID: <20161020195614.GA31016@dft-labs.eu> In-Reply-To: <20161020181827.GU27748@FreeBSD.org> References: <201610191829.u9JITqhm081246@repo.freebsd.org> <20161019220942.GM27748@FreeBSD.org> <20161020115035.GA26990@dft-labs.eu> <20161020181827.GU27748@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 20, 2016 at 11:18:27AM -0700, Gleb Smirnoff wrote: > On Thu, Oct 20, 2016 at 01:50:35PM +0200, Mateusz Guzik wrote: > M> On Wed, Oct 19, 2016 at 03:09:42PM -0700, Gleb Smirnoff wrote: > M> > On Wed, Oct 19, 2016 at 06:29:52PM +0000, Mateusz Guzik wrote: > M> > M> Author: mjg > M> > M> Date: Wed Oct 19 18:29:52 2016 > M> > M> New Revision: 307650 > M> > M> URL: https://svnweb.freebsd.org/changeset/base/307650 > M> > M> > M> > M> Log: > M> > M> cache: split negative entry LRU into multiple lists > M> > M> > M> > M> This splits the ncneg_mtx lock while preserving the hit ratio at least > M> > M> during buildworld. > M> > M> > M> > M> Create N dedicated lists for new negative entries. > M> > M> > M> > M> Entries with at least one hit get promoted to the hot list, where they > M> > M> get requeued every M hits. > M> > M> > M> > M> Shrinking demotes one hot entry and performs a round-robin shrinking of > M> > M> regular lists. > M> > M> > M> > M> Reviewed by: kib > M> > > M> > This instapanics: > M> > > M> > panic: Assertion ncp->nc_flag & NCF_NEGATIVE failed at /usr/src/head/sys/kern/vfs_cache.c:815 > M> > > M> > M> It definitely works for me and I don't see how the condition can fail. > M> > M> Given the 'instapanic' note, I assume you can easily reproduce. Is this > M> a stock head kernel? > M> > M> Can you reproduce with; > > Trying to mount root from ufs:/dev/vtbd0p3 [rw]... > panic: cache_negative_zap_one: ncp 0xffffffff81012500 flag 0 dvp 0 vp 0 > Fixed in r307685. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161020195614.GA31016>