Date: Tue, 24 Aug 2010 00:12:57 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Peter Holm <pho@freebsd.org> Cc: Michael Butler <imb@protected-networks.net>, Jeff Roberson <jroberson@jroberson.net>, current@freebsd.org Subject: Re: softupdate with journal panic Message-ID: <20100823211257.GI2396@deviant.kiev.zoral.com.ua> In-Reply-To: <20100822132104.GA7300@x2.osted.lan> References: <4C7011B9.4020902@protected-networks.net> <20100822132104.GA7300@x2.osted.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, Aug 22, 2010 at 03:21:04PM +0200, Peter Holm wrote: > On Sat, Aug 21, 2010 at 01:49:45PM -0400, Michael Butler wrote: > > While updating sysutils/coreutils port on -current as of this morning > > (SVN r211550), I noted a panic during the directory rename config test. > > > > Your problem seems identical to this report: > > http://docs.freebsd.org/cgi/mid.cgi?AANLkTinPjiOV21kDLZYV5WScrhLMN7DY8E8jVHWPU5mC > I believe that dotdotremref in this case is legitimately NULL. With this assumption, the following patch would help. diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index b666c0f..65e5255 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -6770,7 +6794,8 @@ cancel_diradd(dap, dirrem, jremref, dotremref, dotdotremref) mkdir->md_jaddref = NULL; if (mkdir->md_state & MKDIR_PARENT) { if (cancel_jaddref(jaddref, NULL, - &dirrem->dm_jwork) == 0) { + &dirrem->dm_jwork) == 0 && + dotdotremref != NULL) { free_jremref(dotdotremref); dotdotremref = NULL; } [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxy5FgACgkQC3+MBN1Mb4hzZgCgsd5xo26VcO1Wv1IVtbT+tKKU 8U0AoI9l6QOtkbbysUrxxCBTILLDtUbW =1nI7 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100823211257.GI2396>