Date: Sun, 30 Jun 2013 16:13:59 +0200 From: dt71@gmx.com To: freebsd-current@freebsd.org Subject: Re: another -Wunsequenced topic Message-ID: <51D03D27.3020100@gmx.com> In-Reply-To: <51CEEC34.2010308@gmx.com> References: <51CEEC34.2010308@gmx.com>
next in thread | previous in thread | raw e-mail | index | archive | help
There are more.
Take the first hunk with caution.
Index: contrib/gdb/gdb/dwarf2-frame.c
===================================================================
--- contrib/gdb/gdb/dwarf2-frame.c (revision 252384)
+++ contrib/gdb/gdb/dwarf2-frame.c (working copy)
@@ -1361,7 +1361,7 @@
else if (*augmentation == 'P')
{
/* Skip. */
- buf += size_of_encoded_value (*buf++);
+ buf += size_of_encoded_value (*buf) + 1;
augmentation++;
}
Index: usr.sbin/moused/moused.c
===================================================================
--- usr.sbin/moused/moused.c (revision 252384)
+++ usr.sbin/moused/moused.c (working copy)
@@ -2455,7 +2455,7 @@
return (FALSE);
lbutton = atoi(s);
- arg = skipspace(++arg);
+ arg = skipspace(arg + 1);
s = arg;
while (isdigit(*arg))
++arg;
Index: lib/libstand/nfs.c
===================================================================
--- lib/libstand/nfs.c (revision 252384)
+++ lib/libstand/nfs.c (working copy)
@@ -1465,8 +1465,9 @@
d->d_name[d->d_namlen] = '\0';
pos = roundup(d->d_namlen, sizeof(uint32_t)) / sizeof(uint32_t);
- fp->off = cookie = ((uint64_t)ntohl(rent->nameplus[pos++]) << 32) |
- ntohl(rent->nameplus[pos++]);
+ fp->off = cookie = ((uint64_t)ntohl(rent->nameplus[pos]) << 32) |
+ ntohl(rent->nameplus[pos + 1]);
+ pos += 2;
buf = (u_char *)&rent->nameplus[pos];
return (0);
}
Index: contrib/sendmail/src/recipient.c
===================================================================
--- contrib/sendmail/src/recipient.c (revision 252384)
+++ contrib/sendmail/src/recipient.c (working copy)
@@ -1834,7 +1834,7 @@
/* <sp>#@# introduces a comment anywhere */
/* for Japanese character sets */
- for (p = buf; (p = strchr(++p, '#')) != NULL; )
+ for (p = buf; (p = strchr(p + 1, '#')) != NULL; )
{
if (p[1] == '@' && p[2] == '#' &&
isascii(p[-1]) && isspace(p[-1]) &&
Index: usr.sbin/pkg_install/create/perform.c
===================================================================
--- usr.sbin/pkg_install/create/perform.c (revision 252384)
+++ usr.sbin/pkg_install/create/perform.c (working copy)
@@ -149,7 +149,7 @@
/* Count number of dependencies */
for (cp = Pkgdeps; cp != NULL && *cp != '\0';
- cp = strpbrk(++cp, " \t\n")) {
+ cp = strpbrk(cp + 1, " \t\n")) {
ndeps++;
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51D03D27.3020100>