Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 7 Mar 2004 21:14:26 -0600
From:      Alan Cox <alc@cs.rice.edu>
To:        Peter Wemm <peter@wemm.org>
Cc:        Peter Wemm <peter@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/i386/i386 vm_machdep.c
Message-ID:  <20040308031426.GH21071@cs.rice.edu>
In-Reply-To: <200403071731.14880.peter@wemm.org>
References:  <200403080027.i280RXIC041557@repoman.freebsd.org> <20040308005242.GG21071@cs.rice.edu> <200403071731.14880.peter@wemm.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 07, 2004 at 05:31:14PM -0800, Peter Wemm wrote:
> ...
> 
> Meanwhile, would it be an idea to back out the Giant removal around the 
> kmem_free() in vm_machdep.c?  Its a rarely executed code path.

I see you backed it out.  That's fine.

> I wish there was a way to keep notes about this in the source.  Trying 
> to figure out the quirks of this stuff is painful.

I understand.  There are, however, very few cases like this one.  So,
please don't become gunshy about such changes.

Regards,
Alan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040308031426.GH21071>