Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 4 Jun 1999 10:45:00 +0200
From:      Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
To:        "Justin M. Seger" <jseger@FreeBSD.ORG>
Cc:        girgen@partitur.se, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: ports/net/samba Makefile ports/net/samba/files md5 ports/net/samba/patches patch-ad ports/net/samba/pkg PLIST
Message-ID:  <19990604104500.A17726@internal>
In-Reply-To: <199906040144.SAA60770@freefall.freebsd.org>; from Justin M. Seger on Thu, Jun 03, 1999 at 06:44:55PM -0700
References:  <199906040144.SAA60770@freefall.freebsd.org>
index | next in thread | previous in thread | raw e-mail 

On Thu, 03-Jun-1999 at 18:44:55 -0700, Justin M. Seger wrote:
> jseger      1999/06/03 18:44:55 PDT
> 
>   Modified files:
>     net/samba            Makefile 
>     net/samba/files      md5 
>     net/samba/pkg        PLIST 
>   Removed files:
>     net/samba/patches    patch-ad 
>   Log:
>   Upgrade to 2.0.4b
>   Submitted by:	Palle Girgensohn <girgen@partitur.se>
>   PR:		ports/11877


OK, this seems to be in other hands now, so please let me send
you a bug fix I mailed to hosokawa@ntc.keio.ac.jp about a month
ago. He told me he would look at it but seems to be inactive for
a while now. It would be nice if these two things could be
incorporated into the port.

Thanks,

	-Andre

------------------- snip ------------------

Hi,

thanks for maintaining the samba port. I have found two
small bugs. Well, the first is not a bug it's more a
missing feature:

1. We have got a SAMBA_PRIVATE= setting in the Makefile
   but this is only honored for the install. For building,
   we need the following patch:

--- Makefile.ORI	Wed Mar 10 19:44:08 1999
+++ Makefile	Wed Mar 10 19:44:57 1999
@@ -33,7 +33,7 @@
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--prefix=${PREFIX} --libdir=${SAMBA_CONFDIR} \
 		--localstatedir=${VARDIR} --with-swatdir=${PREFIX}/share/swat \
-		--with-lockdir=${VARDIR}/spool/lock
+		--with-lockdir=${VARDIR}/spool/lock --with-privatedir=${SAMBA_PRIVATE}
 
 WRKSRC=		${WRKDIR}/${DISTNAME}/source


2. For WINS servers, the file wins.dat is created in the lockdir,
   /var/spool/lock. This is cleaned during system startup and so,
   wins.dat is lost.  Unfortunately, wins.dat should survive over
   reboots so I suggest moving it to /var/db. The lockfiles and
   browse.dat should be clean IMHO and can stay in lockdir, of course.

--- nmbd/nmbd_winsserver.c.ORI	Wed Mar 10 19:16:36 1999
+++ nmbd/nmbd_winsserver.c	Wed Mar 10 19:37:11 1999
@@ -152,7 +152,7 @@
   start_async_dns();
 #endif
 
-  pstrcpy(fname,lp_lockdir());
+  pstrcpy(fname,"/var/db");
   trim_string(fname,NULL,"/");
   pstrcat(fname,"/");
   pstrcat(fname,WINS_LIST);
@@ -1551,7 +1551,7 @@
 	  }
   }
 
-  slprintf(fname,sizeof(fname),"%s/%s", lp_lockdir(), WINS_LIST);
+  slprintf(fname,sizeof(fname),"%s/%s", "/var/db", WINS_LIST);
   string_sub(fname,"//", "/");
   slprintf(fnamenew,sizeof(fnamenew),"%s.%u", fname, (unsigned int)getpid());


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990604104500.A17726>