Date: Tue, 22 Jul 2003 15:40:03 +0200 (CEST) From: Harti Brandt <brandt@fokus.fraunhofer.de> To: Bosko Milekic <bmilekic@technokratis.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netatm atm_cm.c atm_socket.c atm_subr.c src/sys/netatm/ipatm ipatm_load.c src/sys/netatm/sigpvc sigpvc_if.c src/sys/netatm/spans spans_arp.c spans_cls.c spans_if.c src/sys/neta Message-ID: <20030722153538.E83041@beagle.fokus.fraunhofer.de> In-Reply-To: <20030722093652.GE58118@technokratis.com> References: <200307221246.h6MCkVMg081118@repoman.freebsd.org> <20030722093652.GE58118@technokratis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 22 Jul 2003, Bosko Milekic wrote: BM> BM>On Tue, Jul 22, 2003 at 05:46:31AM -0700, Hartmut Brandt wrote: BM>> harti 2003/07/22 05:46:31 PDT BM>[...] BM>> Also add rudimentary error handling in some places (panic) when a zone BM>> cannot be created. BM> BM> This is probably a good move but, FWIW, these are never supposed to BM> fail as the UMA zone creation code calls an allocation with M_WAITOK, BM> regardless of who or where the caller is. You are right. Now the handling is at least consistent and things may change... Looking at the (undocumented) flags parameter of uma_zcreate() I would think you could specify M_NOWAIT, but alas these flags serve entirely different purpose (see uma.h). I'll think, I'll keep the panics. harti -- harti brandt, http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030722153538.E83041>