Date: Mon, 19 Aug 2013 18:26:01 +0200 From: Zbyszek Bodek <zbb@semihalf.com> To: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org> Cc: ray@freebsd.org, Alan Cox <alc@cs.rice.edu> Subject: Re: New pmap-v6.c features and improvements Message-ID: <52124719.5000104@semihalf.com> In-Reply-To: <CAG7dG%2BwoHUZp8M_KSMkDy_YNyoC3sLT9qwY_orVqk%2BAoeFpNEA@mail.gmail.com> References: <519B6B1C.9060008@semihalf.com> <20130522184232.GA437@jail.io> <519E0D62.5030708@semihalf.com> <51CC4CC1.4020509@semihalf.com> <51D57456.9080504@semihalf.com> <B6F68E56-7452-44D4-9C9D-195221B06380@bsdimp.com> <51F68F58.8060600@semihalf.com> <CAG7dG%2BwoHUZp8M_KSMkDy_YNyoC3sLT9qwY_orVqk%2BAoeFpNEA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01.08.2013 16:19, Zbigniew Bodek wrote: > 2013/7/29 Zbyszek Bodek <zbb@semihalf.com <mailto:zbb@semihalf.com>> > > On 04.07.2013 19:34, Warner Losh wrote: > > > > On Jul 4, 2013, at 7:10 AM, Zbyszek Bodek wrote: > > > >> On 27.06.2013 16 <tel:27.06.2013%2016>:31, Zbyszek Bodek wrote: > >>> On 23.05.2013 14:36, Zbyszek Bodek wrote: > >>>> On 22.05.2013 20:42, Ruslan Bukin wrote: > >>>>> On Tue, May 21, 2013 at 02:39:56PM +0200, Zbyszek Bodek wrote: > >>>>>> Hello Everyone, > >>>>>> > >>>>>> I would like to introduce another pack of patches for > pmap-v6.c and > >>>>>> related, that we created as a part of Semihalf work on Superpages > >>>>>> support. > >>>>>> > >>>>>> The patches include some major changes like: > >>>>>> > >>>>>> - Switch to AP[1:0] access permissions model > >>>>>> - Transition of the mapping related flags to PTE (stop using > PVF_ flags > >>>>>> in pv_entry) > >>>>>> - Rework of the pmap_enter_locked() function > >>>>>> - pmap code optimizations > >>>>>> > >>>>>> And some minor clean-ups: > >>>>>> > >>>>>> - Get rid of the VERBOSE_INIT_ARM option > >>>>>> - Clean-ups, style and naming improvements to pmap > >>>>>> > >>>>>> Please check out the attachment for details. > >>>>>> > >>>>>> I will be happy to answer your questions and doubts if any. > >>>>>> > >>>>>> Best regards > >>>>>> Zbyszek Bodek > >>>>> > >>>>> I tested new patches with exynos5 and everything is OK. > >>>>> (I mean all works as usual) > >>>>> > >>>> > >>>> Hello. > >>>> > >>>> I'm happy to announce that code has been integrated to the > FreeBSD HEAD. > >>>> Great thanks your help! > >>>> > >>> > >>> Hello Everyone, > >>> > >>> We have two micro patches for pmap-v6.c containing fix for > 'modified' > >>> bit emulation and removal of the redundant PGA_WRITEABLE clearing. > >>> > >>> Please check out the attachment. > >>> > >>> These two are minimal changes and we would like to commit them > soon, so > >>> we would be grateful if you could test them on your ARMv6/v7 > platforms > >>> and give us your remarks. > >>> > >> > >> Hello, > >> > >> Because there were no objections, we've integrated the patches: > >> > >> http://svnweb.freebsd.org/base?view=revision&revision=252694 > >> http://svnweb.freebsd.org/base?view=revision&revision=252695 > > > Hello Everyone, > > I'm sending another set of fixes for pmap-v6.c > Please see attachment. > > 0012 - Removal of the costly, frequent sweeping through the > pv_entries whenever pmap_nuke_pv(), pmap_modify_pv(), etc. > are called. This also makes order with clearing PGA_WRITEABLE > aflag as well as with the pmap_statistics related to the > wired_count. > 0013 - Fix for pamp_set_prot() where not all of the protection bits were > cleared before the actual configuration. L2_XN is not icluded to > the L2_S_PROT mask to maintain consistency between PROT_MASKS for > L2 and L1 descriptors - contain only kernel/user and > read/write permissions bits. > 0014 - Fix for pmap_change_wiring() where "wired" indicator of type > boolean was being used as a "wired flag" passed to > pmap_modify_pv() which was obviously not a valid PVF_WIRED flag. > > Please test those patches on your ARM-based machines and send your > feedback. We will also appreciate your reviews and remarks. > > Thank you in advance for your help. > > > Hello, > > Are there any updates in this topic? > In addition, I'm attaching two more minor improvements, this time: > > 0015 - small clean-ups in pmap_clearbit() that in general gives one relevant > improvement which is to skip redundant "dirty" setting for a > page. > 0016 - removal of the unused pv_kva field from the md_page structure > > If there are no objections to that and earlier presented changes we > would like to > integrate them to the HEAD soon. > Hello, The earlier mentioned patches have been integrated to the FreeBSD HEAD. Please check out below: http://svnweb.freebsd.org/base?view=revision&revision=254531 http://svnweb.freebsd.org/base?view=revision&revision=254532 http://svnweb.freebsd.org/base?view=revision&revision=254533 http://svnweb.freebsd.org/base?view=revision&revision=254535 http://svnweb.freebsd.org/base?view=revision&revision=254536 Best regards Zbyszek Bodek
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52124719.5000104>