Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 02 Apr 2019 04:11:22 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 236935] libxo =text and XOF_FLUSH does not print the first value
Message-ID:  <bug-236935-227-2lNbH53pDO@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-236935-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-236935-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236935

--- Comment #3 from Phil Shafer <phil@freebsd.org> ---
Bug: Bad check for xo_flush_h in xo_transition:

@@ -7884,7 +7882,7 @@ xo_transition (xo_handle_t *xop, xo_xof_flags_t flags,
const char *name,

     /* Handle the flush flag */
     if (rc >=3D 0 && XOF_ISSET(xop, XOF_FLUSH))
-       if (xo_flush_h(xop))
+       if (xo_flush_h(xop) < 0)
            rc =3D -1;

     /* We have now official made output */

Only hits lines with multiple fields when flush is on, and only when certain
fields funnel data thru xo_format_value().

Turns out that xo_transition's call to xo_flush_h is not needed when it's
called from xo_do_emit_fields, so I'll add an explicit call to flush.

Thanks,
 Phil

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236935-227-2lNbH53pDO>