Date: Sun, 14 Apr 2002 16:57:17 -0700 (PDT) From: Frank Mayhar <frank@exit.com> To: hackers@freebsd.org Subject: Minor weirdness in pci/agp_amd.c. Message-ID: <200204142357.g3ENvHFT091843@realtime.exit.com>
next in thread | raw e-mail | index | archive | help
I'm working on writing a driver for the ServerWorks AGP support from the
Linux driver (sans documentation, SIGH :-(). I've been using the various
other drivers as models, particularly the AMD driver, since it seems to be
closest in many ways to the ServerWorks architecture.
Anyway, I've run into a minor oddity in agp_amd_alloc_gatt(), in pci/agp_amd.c.
At lines 120-121:
gatt->ag_pdir = vtophys((vm_offset_t) gatt->ag_vdir);
gatt->ag_pdir = vtophys(gatt->ag_virtual);
Looks like one or the other is redundant? Probably the first, I would guess,
if the code actually works as it is.
--
Frank Mayhar frank@exit.com http://www.exit.com/
Exit Consulting http://www.gpsclock.com/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204142357.g3ENvHFT091843>