Date: Wed, 26 Aug 2020 14:02:38 +0000 (UTC) From: Toomas Soome <tsoome@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r364818 - head/usr.sbin/efibootmgr Message-ID: <202008261402.07QE2c58072480@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: tsoome Date: Wed Aug 26 14:02:38 2020 New Revision: 364818 URL: https://svnweb.freebsd.org/changeset/base/364818 Log: efibootmgr: wrong check for opts.order opts.order && !(opts.order) does not really make sense. Reported by: swildner Modified: head/usr.sbin/efibootmgr/efibootmgr.c Modified: head/usr.sbin/efibootmgr/efibootmgr.c ============================================================================== --- head/usr.sbin/efibootmgr/efibootmgr.c Wed Aug 26 13:13:57 2020 (r364817) +++ head/usr.sbin/efibootmgr/efibootmgr.c Wed Aug 26 14:02:38 2020 (r364818) @@ -295,7 +295,7 @@ parse_args(int argc, char *argv[]) return; } - if (opts.order && !(opts.order)) + if (opts.order != NULL && *opts.order == '\0') errx(1, "%s", ORDER_USAGE); if ((opts.set_inactive || opts.set_active) && !opts.has_bootnum)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008261402.07QE2c58072480>