Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Jun 2023 20:47:09 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: e8cdabb4e135 - main - camcontrol: In defects make -S actually imply 12-byte command
Message-ID:  <202306192047.35JKl9hx095789@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=e8cdabb4e135852b1342f5622beb56e8a04914c1

commit e8cdabb4e135852b1342f5622beb56e8a04914c1
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2023-06-19 20:43:37 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-06-19 20:45:43 +0000

    camcontrol: In defects make -S actually imply 12-byte command
    
    camcontrol(8) says that -S to start at a different offset implies that
    we're using the 12 byte command. But really, we're using the 10-byte
    command. Fix this by setting use_12byte for -S.
    
    Sponsored by:           Netflix
    Reviewed by:            mav
    Differential Revision:  https://reviews.freebsd.org/D40526
---
 sbin/camcontrol/camcontrol.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sbin/camcontrol/camcontrol.c b/sbin/camcontrol/camcontrol.c
index 45b769589da8..4856122a0c07 100644
--- a/sbin/camcontrol/camcontrol.c
+++ b/sbin/camcontrol/camcontrol.c
@@ -3895,6 +3895,7 @@ readdefects(struct cam_device *device, int argc, char **argv,
 				warnx("invalid starting offset %s", optarg);
 				goto defect_bailout;
 			}
+			use_12byte = true;
 			break;
 		}
 		case 'X':



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202306192047.35JKl9hx095789>