Date: Sat, 18 Nov 1995 23:27:45 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@freefall.freebsd.org, j@uriah.heep.sax.de Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa isa.h Message-ID: <199511181227.XAA23409@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> Modified: sys/i386/isa isa.h >> Log: >> Updated comments. The comments about the unused addresses get broken >> almost every time someone uses an address. This file is probably not >> the right place to keep track of the unused addresses (or used >> addresses :->). >Updated... Fixed... perhaps it's also time to finally move out the >timer base frequency #define into isa.h now? (The various definitions >could perhaps be found by "XXX should be in isa.h". :-) I didn't know much about the header layout when I wrote the first of those XXX's. The frequency should be defined in a clock driver `reg.h' file (`reg' is a misleading abbreviation for `mapping of the device registers to i/o or memory and other miscellaneous bus glue). We already have two such files with mostly misplaced things in them: timerreg.h for the `clk0' device rtc.h for the `rtc0' device We should have ic/i825[3-4].h for the clk0 device's ic clkreg.h for the clk0 device's bus glue including TIMER_FREQ ic/mc146818.h for the rtc0 device's ic rtcreg.h for the rtc0 device's bus glue (this is particularly messy because the device registers are multiplexed and some firmware (BIOS) conventions are best recorded here) I won't be cleaning this up any time sonn because I'm sick of cleaning up (and I still have to commit prototype-related changes for about 300 files). Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511181227.XAA23409>