Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Nov 2015 23:39:35 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Jason Unovitch <jason.unovitch@gmail.com>
Cc:        =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r291453 - head/lib/libfetch
Message-ID:  <0BD9830A-9592-46AD-B626-4E75948C8A2A@FreeBSD.org>
In-Reply-To: <CABW2x9oSjevQswLGworjomQMTKeZfjt2EE9ZC2WD8bThsR=DpQ@mail.gmail.com>
References:  <201511291427.tATER0lb011244@repo.freebsd.org> <CABW2x9oSjevQswLGworjomQMTKeZfjt2EE9ZC2WD8bThsR=DpQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On 29 Nov 2015, at 18:35, Jason Unovitch <jason.unovitch@gmail.com> wrote:
> 
> On Sun, Nov 29, 2015 at 9:27 AM, Dag-Erling Smørgrav <des@freebsd.org> wrote:
>> Author: des
>> Date: Sun Nov 29 14:26:59 2015
>> New Revision: 291453
>> URL: https://svnweb.freebsd.org/changeset/base/291453
...
> `make buildworld` fails after this commit:
> 
> /usr/src/head/lib/libfetch/http.c:1692:25: error: address of array
> 'url->user' will always evaluate to 'true' [-Werro
> r,-Wpointer-bool-conversion]
>                                aparams.user = url->user ?
>                                               ~~~~~^~~~ ~
> /usr/src/head/lib/libfetch/http.c:1694:29: error: address of array
> 'url->pwd' will always evaluate to 'true' [-Werror
> ,-Wpointer-bool-conversion]
>                                aparams.password = url->pwd ?

This should now be fixed by r291461.

-Dimitry


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.28

iEYEARECAAYFAlZbfq8ACgkQsF6jCi4glqNiRACeNGyL7yFUafQBmpBYampgbDPD
uWsAoO7m2fYeqC+/mubj4alfWqeteU/N
=ImJM
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0BD9830A-9592-46AD-B626-4E75948C8A2A>