Date: Thu, 27 Apr 2006 15:00:31 GMT From: "Andrew Pantyukhin" <infofarmer@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/95884: update multimedia/mplayer - libtheora fix Message-ID: <200604271500.k3RF0Vfu057083@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/95884; it has been noted by GNATS.
From: "Andrew Pantyukhin" <infofarmer@gmail.com>
To: "Thomas E. Zander" <riggs@rrr.de>
Cc: bug-followup@freebsd.org
Subject: Re: ports/95884: update multimedia/mplayer - libtheora fix
Date: Thu, 27 Apr 2006 18:52:11 +0400
On 4/27/06, Thomas E. Zander <riggs@rrr.de> wrote:
> Am Sat, dem 22. Apr 2006, um 11:06 +0400 Uhr schrubte Andrew Pantyukhin
> zum Thema [Re: ports/95884: update multimedia/mplayer - libtheora fix]:
>
> > This tweak doesn't break anything, I don't think it will until
> > something like theora 2.0 which is a long wait from now.
>
> But you really shouldn't do this in your patch:
>
> -LIB_DEPENDS+=3D theora.1:${PORTSDIR}/multimedia/libtheora
> +LIB_DEPENDS+=3D theora:${PORTSDIR}/multimedia/libtheora
>
> Instead, as your patch bumps theora's major to 2, this one,
>
> -LIB_DEPENDS+=3D theora.1:${PORTSDIR}/multimedia/libtheora
> +LIB_DEPENDS+=3D theora.2:${PORTSDIR}/multimedia/libtheora
>
> would me much more agreeable.
Okay, I'm not experiemced enough to argue and it's
your call anyway.
This PR (with the above-suggested change) is now
dependent on PR #95870
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604271500.k3RF0Vfu057083>