Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 5 Apr 2023 17:48:03 +0200
From:      =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: e933541b2131 - main - devel/samurai: Fix if LOCALBASE is not /usr/local
Message-ID:  <CAGwOe2YbYHAfgmYP5b7FEw_rSPvypftBCEVkFOJhxT8kuHxQ=g@mail.gmail.com>
In-Reply-To: <ZC0qFG4RJTMQ5sx%2B@FreeBSD.org>
References:  <202304050543.3355hcZX012345@gitrepo.freebsd.org> <ZC0qFG4RJTMQ5sx%2B@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
On Wed, Apr 5, 2023 at 9:58 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote:
> > commit e933541b2131d644ce243630544bcf210fb4be84
> >
> >   devel/samurai: Fix if LOCALBASE is not /usr/local
> >
> >   PR:             270590
> >   Reported by:    eric@camachat.org
> > ...
> >  PORTNAME=    samurai
> >  DISTVERSION= 1.2-16
> > +PORTREVISION=        1
>
> Needless bump for build-time change?
>
> > -@@ -3,7 +3,7 @@
> > - PREFIX=/usr/local
> > +@@ -1,10 +1,10 @@
> > + .POSIX:
> > + .PHONY: all install clean
> > +
> > +-PREFIX=/usr/local
> > ++PREFIX=${LOCALBASE}
>
> This doesn't look right, PREFIX is semantically different from LOCALBASE
> even
> though they typically point to the same path (PREFIX is where your
> generated
> stuff goes, LOCALBASE is where you get precursors).  If this program abuses
> the PREFIX variable and it is actually meant to be LOCALBASE, it's better
> to
> fix the Makefile or at least accompany such change with due comment.
>
>
Should be correct now.

Thanks!


> ./danfe
>

[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 5, 2023 at 9:58 AM Alexey Dokuchaev &lt;<a href="mailto:danfe@freebsd.org">danfe@freebsd.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote:<br>
&gt; commit e933541b2131d644ce243630544bcf210fb4be84<br>
&gt; <br>
&gt;   devel/samurai: Fix if LOCALBASE is not /usr/local<br>
&gt;     <br>
&gt;   PR:             270590<br>
&gt;   Reported by:    <a href="mailto:eric@camachat.org" target="_blank">eric@camachat.org</a><br>
&gt; ...<br>
&gt;  PORTNAME=    samurai<br>
&gt;  DISTVERSION= 1.2-16<br>
&gt; +PORTREVISION=        1<br>
<br>
Needless bump for build-time change?<br>
<br>
&gt; -@@ -3,7 +3,7 @@<br>
&gt; - PREFIX=/usr/local<br>
&gt; +@@ -1,10 +1,10 @@<br>
&gt; + .POSIX:<br>
&gt; + .PHONY: all install clean<br>
&gt; + <br>
&gt; +-PREFIX=/usr/local<br>
&gt; ++PREFIX=${LOCALBASE}<br>
<br>
This doesn&#39;t look right, PREFIX is semantically different from LOCALBASE even<br>
though they typically point to the same path (PREFIX is where your generated<br>
stuff goes, LOCALBASE is where you get precursors).  If this program abuses<br>
the PREFIX variable and it is actually meant to be LOCALBASE, it&#39;s better to<br>
fix the Makefile or at least accompany such change with due comment.<br>
<br></blockquote><div><br></div><div>Should be correct now.</div><div><br></div><div>Thanks!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
./danfe<br>
</blockquote></div></div>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YbYHAfgmYP5b7FEw_rSPvypftBCEVkFOJhxT8kuHxQ=g>