Date: Thu, 30 Dec 2004 17:08:10 +0200 From: Maxim Sobolev <sobomax@portaone.com> To: Peter Pentchev <roam@ringlet.net> Cc: Matteo Riondato <rionda@gufi.org> Subject: Re: Creating Compressed Loop FS from stdin Message-ID: <41D419DA.4050603@portaone.com> In-Reply-To: <20041230145949.GK830@straylight.m.ringlet.net> References: <1104358540.2895.10.camel@kaiser.sig11.org> <20041230103433.GB830@straylight.m.ringlet.net> <1104409708.6657.1.camel@kaiser.sig11.org> <20041230123116.GE830@straylight.m.ringlet.net> <41D4036B.1060600@portaone.com> <20041230140007.GH830@straylight.m.ringlet.net> <41D40EA0.2060009@portaone.com> <20041230145543.GJ830@straylight.m.ringlet.net> <20041230145949.GK830@straylight.m.ringlet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Never mind - people are inheretedly error prone creatures. ;-) In your case shell has been passing file descriptor of the open file, not pipe, so that seeking has been working properly. Anyway, I think that your patch is useful, since it should allow using disk devices. -Maxim Peter Pentchev wrote: > On Thu, Dec 30, 2004 at 04:55:43PM +0200, Peter Pentchev wrote: > >>On Thu, Dec 30, 2004 at 04:20:16PM +0200, Maxim Sobolev wrote: >> >>>You don't check return code of the second lseek - I bet it fails. This >>>probably leads to creation of seemingly valid loop fs (i.e. with valid >>>header), but filled with zeroes or some random junk. >> >>I said I'd tested it before posting it the first time. It works. >>It creates a valid loop fs, containing exactly the files that are in >>the input ISO image. > > > Errr. Oops. > > Sorry everyone - the patch does not really work. I keep testing it with > a *file* passed on mkuzip's stdin, all the while feeling surprised that > lseek() works on the pipe... when there is no pipe at all :( > > I just tested it with a real pipe, and of course, it failed. Again, > sorry for wasting your time; I guess it'd be best if I tucked in for > the holidays now :( > > G'luck, > Peter >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41D419DA.4050603>