Date: Thu, 3 Mar 2005 16:14:36 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: Joerg Wunsch <joerg@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/alpha/include _types.h atomic.h cpufunc.h limits.h stdarg.h varargs.h src/sys/amd64/amd64 fpu.c... Message-ID: <20050303161436.0cczcopocg84g4ks@netchild.homeip.net> In-Reply-To: <200503022133.j22LXTih011115@repoman.freebsd.org> References: <200503022133.j22LXTih011115@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Joerg Wunsch <joerg@freebsd.org> wrote: > Log: > netchild's mega-patch to isolate compiler dependencies into a central > place. Thank you. > This moves the dependency on GCC's and other compiler's features into > the central sys/cdefs.h file, while the individual source files can > then refer to #ifdef __COMPILER_FEATURE_FOO where they by now used to > refer to #if __GNUC__ > 3.1415 && __BARC__ <= 42. I haven't converted compat/* files. Also not converted are files which got __GNUC__ dependencies in the last month. I try to get time to scan for them. New code shouldn't use __GNUC__ anymore off course. If cdefs.h doesn't contain a define which fits your needs, add a new one please. > Reviewed by: various developers on arch@, some time ago We wheren't happy about the names of the defines, but we wheren't able to come up with better ones. So in case you're not happy with the names used feel free to come up with better ones (I don't intend to participate in such a discussion). The patch works for me since a year without any problem, but I don't have every hardware which is touched by this commit. So no guarantees that it won't eat your family. :-) Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 I am not now and never have been a girl friend of Henry Kissinger. -- Gloria Steinem
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050303161436.0cczcopocg84g4ks>