Date: Fri, 10 May 2013 14:57:45 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Martin Wilke <miwi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r317806 - in head/archivers/unalz: . files Message-ID: <20130510145745.GA22175@FreeBSD.org> In-Reply-To: <201305101431.r4AEVE2h009902@svn.freebsd.org> References: <201305101431.r4AEVE2h009902@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 10, 2013 at 02:31:14PM +0000, Martin Wilke wrote: > New Revision: 317806 > URL: http://svnweb.freebsd.org/changeset/ports/317806 > > Log: > - Fix build > > PR: 178154 > Submitted by: Ports Fury While most of the Kato's work are of rather high quality and quite accurate with the details down to licensing issues, this particular change: > do-install: > - ${INSTALL_PROGRAM} ${WRKSRC}/unalz ${PREFIX}/bin > + (cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin) is gratuitous and should not have been committed. I think I've previously raise this concern with Kato's submissions before. Not just it does not win us anything here, it makes install(1) statement context-dependent and also reduces readability thereof at the same time. No matter how good is Kato (whoever they are), we should not handle their patches blindly. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130510145745.GA22175>