Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 May 2018 23:25:06 +0300
From:      Ivan Klymenko <fidaj@ukr.net>
To:        Sean Bruno <sbruno@freebsd.org>
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   Re: svn commit: r334229 - stable/11/sys/cam
Message-ID:  <20180527232459.2512292c@nonamehost>
In-Reply-To: <54a68cc7-085a-e6f1-b5d1-cdb80dfadd9c@freebsd.org>
References:  <201805252318.w4PNI6X5054481@repo.freebsd.org> <20180527111622.1242fdb0@nonamehost> <bc438328-db9a-43b5-2b21-7431dde1879a@freebsd.org> <20180527230142.7bbddd6c@nonamehost> <54a68cc7-085a-e6f1-b5d1-cdb80dfadd9c@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
=D0=92 Sun, 27 May 2018 14:05:18 -0600
Sean Bruno <sbruno@freebsd.org> =D0=BF=D0=B8=D1=88=D0=B5=D1=82:

> On 05/27/18 14:01, Ivan Klymenko wrote:
> > =D0=92 Sun, 27 May 2018 11:21:16 -0600
> > Sean Bruno <sbruno@freebsd.org> =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >  =20
> >> On 05/27/18 02:16, Ivan Klymenko wrote: =20
> >>> --- cam_iosched.o ---
> >>> /usr/local/libexec/ccache/world/cc -target
> >>> i386-unknown-freebsd11.2 --sysroot=3D/usr/obj/usr/src/tmp
> >>> -B/usr/obj/usr/src/tmp/usr/bin -O2 -pipe -O3 -fvectorize
> >>> -fslp-vectorize -fblocks -march=3Dnative -fno-strict-aliasing
> >>> -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> >>> -DHAVE_KERNEL_OPTION_HEADERS
> >>> -include /usr/obj/usr/src/sys/k11/opt_global.h -I. -I/usr/src/sys
> >>> -fno-common -g -I/usr/obj/usr/src/sys/k11   -MD
> >>> -MF.depend.cam_iosched.o -MTcam_iosched.o -mno-mmx -mno-sse
> >>> -msoft-float -ffreestanding -fwrapv -fstack-protector -gdwarf-2
> >>> -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> >>> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
> >>> -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__
> >>> -Wmissing-include-dirs -fdiagnostics-show-option
> >>> -Wno-unknown-pragmas -Wno-error-tautological-compare
> >>> -Wno-error-empty-body -Wno-error-parentheses-equality
> >>> -Wno-error-unused-function -Wno-error-pointer-sign
> >>> -Wno-error-shift-negative-value
> >>> -Wno-error-address-of-packed-member  -Ofast -fvectorize
> >>> -fslp-vectorize -fblocks -fcolor-diagnostics -mno-aes -mno-avx
> >>> -std=3Diso9899:1999 -c /usr/src/sys/cam/cam_iosched.c -o
> >>> cam_iosched.o /usr/src/sys/cam/cam_iosched.c:513:40: error: no
> >>> member named 'quanta1' in 'struct cam_iosched_softc'; did you
> >>> mean 'quanta'? callout_reset(&isc->ticker, hz / isc->quanta1,
> >>> cam_iosched_ticker, isc); ^~~~~~~ quanta   =20
> >>
> >>
> >> Is this a CCACHE failure?  I don't see this error on i386 builds
> >> kernel.
> >>
> >> sean
> >> =20
> >=20
> > Yes you are right. But such a long time did not happen with ccache.
> >=20
> > Sorry.
> >=20
> >  =20
>=20
>=20
> No problem.  Do you know why it failed?
>=20
> sean
>=20
Ops.
All the same, most likely because of this:

-	callout_reset(&isc->ticker, hz / isc->quanta - 1, cam_iosched_ticker, isc=
);
+	callout_reset(&isc->ticker, hz / isc->quanta1, cam_iosched_ticker, isc);
to

-	callout_reset(&isc->ticker, hz / isc->quanta - 1, cam_iosched_ticker, isc=
);
+	callout_reset(&isc->ticker, hz / isc->quanta, cam_iosched_ticker, isc);

ccache here not guilty.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180527232459.2512292c>