Date: Tue, 6 Jul 2010 02:25:37 +0400 From: Max Brazhnikov <makc@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: cvs-all@freebsd.org, ports-committers@freebsd.org, Dmitry Marakasov <amdmi3@amdmi3.ru>, cvs-ports@freebsd.org, Rene Ladan <rene@freebsd.org>, Dima Panov <fluffy@freebsd.org> Subject: Re: cvs commit: ports/devel/cmake Makefile distinfo pkg-plist ports/devel/cmake-gui Makefile distinfo Message-ID: <201007060225.37423.makc@freebsd.org> In-Reply-To: <20100522111916.GB49597@FreeBSD.org> References: <200911291151.nATBpdsp044837@repoman.freebsd.org> <201005221405.42362.makc@freebsd.org> <20100522111916.GB49597@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 22 May 2010 11:19:16 +0000, Alexey Dokuchaev wrote:
> On Sat, May 22, 2010 at 02:05:42PM +0400, Max Brazhnikov wrote:
> > On Fri, 21 May 2010 22:22:34 +0200, Rene Ladan wrote:
> > > > Yeah, I've also had to explicitly provide path to wxgtk2-2.8-config
> > > > for my CMake-based ports as well. Probably some sort of hack we
> > > > used to employ for sdl12-config is in order; creating symlink seems
> > > > bad since target might be something other than wxgtk2-2.8-config,
> > > > leading to potential conflicts. We have a long record of dealing
> > > > with local differences from the rest of the [GNU/OSS] world in a
> > > > sane ways. :-)
> > >
> > > I've sent a patch for this with ports/146805
> >
> > With this patch cmake/wx-based ports will always try to build with wx-2.8
> > when multiple wx ports are installed, disregarding what ports/user
> > request.
> >
> > Wouldn't better to pass ${WX_CONFIG} for CMAKE_ARGS in bsd.wx.mk, as it
> > does already for CONFIGURE_ARGS?
>
> Hmm. Actually, that's pretty much what people do with their ports to
> hack around this problem (line from one of mine):
>
> CMAKE_ARGS= -DwxWidgets_CONFIG_EXECUTABLE="${WX_CONFIG}"
>
> Maybe we should just += this value to CMAKE_ARGS when appropriate (read:
> when USE_WX) and be done this it?
The issue will be fixed with next update (after freeze over), the patch is
available at
http://people.freebsd.org/~makc/patches/cmake-2.8.2.diff
Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007060225.37423.makc>
