Date: Wed, 29 Sep 2021 18:17:28 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Koichiro Iwao <meta@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4886d3afe2ed - main - x11-fm/mucommander: unbreak Message-ID: <YVStuIrF780IhE3r@FreeBSD.org> In-Reply-To: <202109291154.18TBssAe054689@gitrepo.freebsd.org> References: <202109291154.18TBssAe054689@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 29, 2021 at 11:54:54AM +0000, Koichiro Iwao wrote:
> commit 4886d3afe2edc47f40839f972a1891c0dbd64d65
>
> x11-fm/mucommander: unbreak
>
> ...
> @@ -28,7 +26,7 @@ OPTIONS_DEFINE= DOCS
>
> do-install:
> @${MKDIR} ${STAGEDIR}${DATADIR}
> - ${INSTALL_DATA} ${WRKSRC}/mucommander.jar ${STAGEDIR}${DATADIR}
> + ${INSTALL_DATA} ${WRKSRC}/mucommander-0.9.5.jar ${STAGEDIR}${DATADIR}/mucommander.jar
It's generally a bad idea to hardcode version numbers in targets recipes,
as it would have to be changed upon next update. Why not use something
like ${PORTVERSION:R} instead, in this particular case?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVStuIrF780IhE3r>